Skip to content

pkg/testgridanalysis/testidentification: Fix "not a valid bugzilla component" Errorf#112

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:invalid-bugzilla-component-reporting
Sep 29, 2020
Merged

pkg/testgridanalysis/testidentification: Fix "not a valid bugzilla component" Errorf#112
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:invalid-bugzilla-component-reporting

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Sep 29, 2020

Fixing a bug from 0ff3699 (#69) to avoid:

$ go test ./...
pkg/testgridanalysis/testidentification/component.go:168:10: Errorf format %q reads arg #1, but call has 0 args
pkg/testgridanalysis/testidentification/component.go:176:10: Errorf format %q reads arg #1, but call has 0 args
...

…mponent" Errorf

Fixing a bug from 0ff3699 (add failures by BZ component,
2020-09-01, openshift#69) to avoid:

  $ go test ./...
  # github.com/openshift/sippy/pkg/testgridanalysis/testidentification
  pkg/testgridanalysis/testidentification/component.go:168:10: Errorf format %q reads arg openshift#1, but call has 0 args
  pkg/testgridanalysis/testidentification/component.go:176:10: Errorf format %q reads arg openshift#1, but call has 0 args
  ...
@bparees
Copy link
Copy Markdown
Contributor

bparees commented Sep 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit b9b737d into openshift:master Sep 29, 2020
@wking wking deleted the invalid-bugzilla-component-reporting branch September 29, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants