Skip to content

TRT-2198: aro-integration fixes#2861

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
sosiouxme:20250808-aro-integration-fixes
Aug 8, 2025
Merged

TRT-2198: aro-integration fixes#2861
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
sosiouxme:20250808-aro-integration-fixes

Conversation

@sosiouxme
Copy link
Member

fix some issues that I discovered after rolling out #2857

the updated BQ table only has 'featureGates' capability for the right
releases. just use that instead of comparing release versions.
that includes risk analysis
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 8, 2025

@sosiouxme: This pull request references TRT-2198 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

fix some issues that I discovered after rolling out #2857

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deepsm007 and smg247 August 8, 2025 21:14
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2025

@sosiouxme: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

stbenjam commented Aug 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sosiouxme, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4f1a2c3 into openshift:main Aug 8, 2025
7 checks passed
@sosiouxme sosiouxme deleted the 20250808-aro-integration-fixes branch August 8, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants