TRT-2495: Generate test details url with proper cross compare query parameters

[xueqzhan]

Summary by CodeRabbit

• New Features

  • Added support for cross-variant parameters in URL generation with deterministic ordering through key and value sorting.

• Tests

  • New test case added to verify cross-variant parameter inclusion and correct ordering in generated URLs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2495 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Adds support for cross-variant parameters (CompareVariants and VariantCrossCompare) to URL generation in GenerateTestDetailsURL by implementing deterministic ordering through key and value sorting before appending query parameters. Includes corresponding test case verifying parameter presence and correct ordering.

Changes

Cohort / File(s)	Summary
Core URL generation logic pkg/api/componentreadiness/utils/utils.go	Implements processing of CompareVariants and VariantCrossCompare parameters with sorted key/value ordering before appending to query string in GenerateTestDetailsURL function.
Test coverage pkg/api/componentreadiness/utils/utils_test.go	Adds new test case validating cross-compare parameter inclusion and verifying deterministic ordering of variantCrossCompare and compareVariant parameters (Architecture before Topology).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Single Responsibility And Clear Naming	⚠️ Warning	The GenerateTestDetailsURL function violates single responsibility by handling URL construction, query parameter assembly, variant parsing, and release formatting across 161 lines with 10 parameters exceeding guideline limits, while package name 'utils' is a generic anti-pattern lacking context.	Refactor: rename package to specific name, introduce builder pattern to reduce parameters, extract variant handling into dedicated functions, and separate URL construction from parameter assembly.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding proper cross-compare query parameters to test details URL generation.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Go Error Handling	✅ Passed	The code changes follow proper Go error handling patterns with correct error returns, fmt.Errorf usage, nil checks, and no ignored errors or panic calls.
Sql Injection Prevention	✅ Passed	The PR modifies URL generation functionality (GenerateTestDetailsURL) to add cross-variant query parameters. This is URL parameter construction, not SQL query construction, so SQL injection checks are not applicable.
Excessive Css In React Should Use Styles	✅ Passed	This check is not applicable to the provided pull request. The PR modifies Go backend files that handle URL parameter generation, not React components with CSS styling.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@xueqzhan: This pull request references TRT-2495 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

• New Features

• Added support for cross-variant parameters in URL generation with deterministic ordering through key and value sorting.

• Tests

• New test case added to verify cross-variant parameter inclusion and correct ordering in generated URLs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[xueqzhan]

/test unit

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw,xueqzhan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@xueqzhan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.