Skip to content

Add annotation field to /api/jobs/runs from BQ#3312

Open
abiduke612 wants to merge 2 commits intoopenshift:mainfrom
abiduke612:abbyduke/add-annotations-jobrunapi
Open

Add annotation field to /api/jobs/runs from BQ#3312
abiduke612 wants to merge 2 commits intoopenshift:mainfrom
abiduke612:abbyduke/add-annotations-jobrunapi

Conversation

@abiduke612
Copy link

Wired annotation data from BQ through postgres and into the /api/jobs/runs response, storing them in a normalized prow_job_run_annotations table and fetching post-pagination to avoid adding cost to the materialized view refresh.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

Hi @abiduke612. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from sosiouxme and stbenjam March 6, 2026 00:46
@abiduke612 abiduke612 force-pushed the abbyduke/add-annotations-jobrunapi branch from acb8719 to ba47133 Compare March 6, 2026 00:55
@stbenjam
Copy link
Member

stbenjam commented Mar 6, 2026

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 6, 2026
…zed view for jobRunsReportMatView to return in api response to jobs/runs
@abiduke612 abiduke612 force-pushed the abbyduke/add-annotations-jobrunapi branch from ba47133 to 86828fb Compare March 6, 2026 18:40
@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@sosiouxme
Copy link
Member

trying to figure out what this is coming from in e2e failure:

time="2026-03-06T19:03:16.743Z" level=error msg="error querying jobs from bigquery" error="googleapi: Error 400: Unrecognized name: annotations at [15:25], invalidQuery"

@abiduke612
Copy link
Author

trying to figure out what this is coming from in e2e failure:

time="2026-03-06T19:03:16.743Z" level=error msg="error querying jobs from bigquery" error="googleapi: Error 400: Unrecognized name: annotations at [15:25], invalidQuery"

It comes from my addition to the query here: https://github.com/openshift/sippy/pull/3312/changes#diff-53500d32cefc4e92e6fac07b981e215c7567565b789e058316ac2c4b6ad187cbR53:~:text=%2B-,annotations%2C,-52

I unfortunately don't have access to the dataset itself to verify that my assumption about the schema is correct (to use when selecting the annotations column). Would you have any info about that @sosiouxme ?

Copy link
Member

@sosiouxme sosiouxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly concerned that it will slow down test page loading which is already slow, but cautiously OK with the idea. Gotta get it actually working with BQ though.

@sosiouxme
Copy link
Member

I'm not sure we have any credentials we can safely give folks outside the team to test such things. I guess the e2e job must do at least minimal testing of the prow loader to hit this error, but probably a TRT member really should run it to get confirmation that it's working.

@abiduke612
Copy link
Author

I'm not sure we have any credentials we can safely give folks outside the team to test such things. I guess the e2e job must do at least minimal testing of the prow loader to hit this error, but probably a TRT member really should run it to get confirmation that it's working.

What do you recommend as next steps for me? I don't have access to the GCP project to create a service account credential

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abiduke612
Once this PR has been reviewed and has the lgtm label, please ask for approval from sosiouxme. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

@abiduke612: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants