Add annotation field to /api/jobs/runs from BQ#3312
Add annotation field to /api/jobs/runs from BQ#3312abiduke612 wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Hi @abiduke612. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
acb8719 to
ba47133
Compare
|
/ok-to-test |
…zed view for jobRunsReportMatView to return in api response to jobs/runs
ba47133 to
86828fb
Compare
|
Scheduling required tests: |
|
trying to figure out what this is coming from in e2e failure:
|
It comes from my addition to the query here: https://github.com/openshift/sippy/pull/3312/changes#diff-53500d32cefc4e92e6fac07b981e215c7567565b789e058316ac2c4b6ad187cbR53:~:text=%2B-,annotations%2C,-52 I unfortunately don't have access to the dataset itself to verify that my assumption about the schema is correct (to use when selecting the |
|
I'm not sure we have any credentials we can safely give folks outside the team to test such things. I guess the e2e job must do at least minimal testing of the prow loader to hit this error, but probably a TRT member really should run it to get confirmation that it's working. |
What do you recommend as next steps for me? I don't have access to the GCP project to create a service account credential |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abiduke612 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Scheduling required tests: |
|
@abiduke612: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Wired annotation data from BQ through postgres and into the /api/jobs/runs response, storing them in a normalized prow_job_run_annotations table and fetching post-pagination to avoid adding cost to the materialized view refresh.