Fix npm audit vulnerabilities in production dependencies#3372
Fix npm audit vulnerabilities in production dependencies#3372openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
Update picomatch and yaml to patched versions to resolve high severity ReDoS and moderate severity stack overflow vulnerabilities. Also update the Makefile to use --omit=dev instead of the deprecated --production flag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughMakefile: updated the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The flatted npm package ships Go source code that triggers gocyclo and gocritic violations. Exclude node_modules from the linter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/lgtm |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stbenjam: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
picomatchandyamlto patched versions to resolve production dependency vulnerabilities (high severity ReDoS, moderate severity stack overflow)--omit=devinstead of deprecated--productionflag fornpm auditTest plan
cd sippy-ng && npm audit --omit=devreports 0 vulnerabilitiesmake lintpasses🤖 Generated with Claude Code
Summary by CodeRabbit