Skip to content

Fix npm audit vulnerabilities in production dependencies#3372

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
stbenjam:npm-fix
Mar 26, 2026
Merged

Fix npm audit vulnerabilities in production dependencies#3372
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
stbenjam:npm-fix

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Mar 26, 2026

Summary

  • Update picomatch and yaml to patched versions to resolve production dependency vulnerabilities (high severity ReDoS, moderate severity stack overflow)
  • Update Makefile to use --omit=dev instead of deprecated --production flag for npm audit

Test plan

  • cd sippy-ng && npm audit --omit=dev reports 0 vulnerabilities
  • make lint passes

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the dependency-audit behavior in build tooling to change which packages are included during audits.
    • Excluded the frontend dependency directory from lint runs to reduce unnecessary scanning and noise during linting.

Update picomatch and yaml to patched versions to resolve high severity
ReDoS and moderate severity stack overflow vulnerabilities. Also update
the Makefile to use --omit=dev instead of the deprecated --production
flag.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from smg247 and xueqzhan March 26, 2026 12:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1f59d516-8fdd-4f85-a670-1ca1136ead7b

📥 Commits

Reviewing files that changed from the base of the PR and between af43d34 and 0c131f5.

📒 Files selected for processing (1)
  • .golangci.yml
✅ Files skipped from review due to trivial changes (1)
  • .golangci.yml

Walkthrough

Makefile: updated the lint target's npm audit command to npm audit --omit=dev (replacing --production). .golangci.yml: added run.skip-dirs to exclude sippy-ng/node_modules from golangci-lint runs. No other behavior or exports changed.

Changes

Cohort / File(s) Summary
Build / Makefile
Makefile
Replaced npm audit --production with npm audit --omit=dev in the lint target to change which dependencies are audited.
Linter config
.golangci.yml
Added run.skip-dirs entry to exclude sippy-ng/node_modules from golangci-lint execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Go Error Handling ✅ Passed The custom check for Go error handling patterns is not applicable to this PR, which only modifies configuration files (Makefile and .golangci.yml) without any changes to Go source code.
Sql Injection Prevention ✅ Passed The pull request contains only configuration file updates to Makefile and .golangci.yml with no SQL query or database operation changes.
Excessive Css In React Should Use Styles ✅ Passed This custom check for excessive CSS in React components is not applicable as the PR only modifies build and linting configuration files without touching any React component files.
Single Responsibility And Clear Naming ✅ Passed This PR contains only configuration file changes (Makefile and .golangci.yml) with no modifications to Go code, packages, structs, or method definitions.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
The flatted npm package ships Go source code that triggers gocyclo and
gocritic violations. Exclude node_modules from the linter.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dgoodwin
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

@stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ba3d7ee into openshift:main Mar 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants