Skip to content

Add ARO classic (ARO-RP) prow jobs to sippy config #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abiduke612 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Add ARO classic (ARO-RP) prow jobs to sippy config #3500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions config/openshift-customizations.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,18 @@ releases:
periodic-ci-Azure-ARO-HCP-main-periodic-prod-uksouth-e2e-parallel: true
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-nightly: true
branch-ci-Azure-ARO-HCP-main-e2e-prod-e2e-parallel: true
aro-classic-integration:
Copy link
Copy Markdown
Member

@stbenjam stbenjam May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this release exist yet?

jobs:
periodic-ci-Azure-ARO-RP-master-periodic-integration-e2e-parallel-csp: true
periodic-ci-Azure-ARO-RP-master-periodic-integration-e2e-parallel-miwi: true
aro-classic-stage:
jobs:
periodic-ci-Azure-ARO-RP-master-periodic-stage-e2e-parallel-csp: true
periodic-ci-Azure-ARO-RP-master-periodic-stage-e2e-parallel-miwi: true
aro-classic-production:
jobs:
periodic-ci-Azure-ARO-RP-master-periodic-prod-e2e-parallel-csp: true
periodic-ci-Azure-ARO-RP-master-periodic-prod-e2e-parallel-miwi: true
Comment on lines +41 to +52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Current Presubmits config:"
sed -n '16,22p' config/openshift-customizations.yaml

echo
echo "ARO Classic pull jobs currently exposed by prow:"
curl -fsSL https://prow.ci.openshift.org/prowjobs.js \
  | rg -o 'pull-ci-Azure-ARO-RP-master[^"]*' \
  | sort -u

Repository: openshift/sippy

Length of output: 1326

Add ARO-RP-master pull jobs to the Presubmits pattern.

The Presubmits pseudorelease (line 21) still only matches ^pull-ci-Azure-ARO-HCP-main.*. However, prow contains pull-ci-Azure-ARO-RP-master-images pull jobs for ARO Classic that are not currently covered. Add ^pull-ci-Azure-ARO-RP-master.* to the Presubmits regexp list to ensure Classic pull job results surface in Sippy alongside the periodic jobs added in lines 41–52.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@config/openshift-customizations.yaml` around lines 41 - 52, Presubmits
pseudorelease's regex currently only matches ^pull-ci-Azure-ARO-HCP-main.* and
therefore misses ARO Classic pull jobs; update the Presubmits regexp list to
include ^pull-ci-Azure-ARO-RP-master.* so pull-ci-Azure-ARO-RP-master-images and
other RP-master pull jobs are matched and surface in Sippy alongside the added
periodic jobs; locate the Presubmits entry (symbol: Presubmits) and append the
^pull-ci-Azure-ARO-RP-master.* pattern to its regex array.

rosa-stage:
jobs:
# ROSA Classic/STS nightly (stage)
Expand Down