OCPNODE-4125: Promote disruptive long-running jobs to candidate tier for stabilization

[QiWang19]

Summary by CodeRabbit

• Configuration Updates

  • Updated job tier classification for disruptive long-running jobs from hidden to candidate across relevant variants.

• Tests

  • Added test cases validating detection and classification of disruptive long-running job names, including a tech-preview variant.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[QiWang19]

/pipeline required

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci-robot]

@QiWang19: This pull request references OCPNODE-4125 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9cae023e-fd48-4c02-8fb2-1b7c57943b13

📥 Commits

Reviewing files that changed from the base of the PR and between 72b8b34 and 9d78599.

📒 Files selected for processing (3)

• pkg/variantregistry/ocp.go
• pkg/variantregistry/ocp_test.go
• pkg/variantregistry/snapshot.yaml

✅ Files skipped from review due to trivial changes (1)

• pkg/variantregistry/snapshot.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• pkg/variantregistry/ocp.go

---

Walkthrough

This PR adds a job-tier classification rule for job names containing -disruptive-longrunning, classifying them as candidate, and updates the variant snapshot entries accordingly; tests exercising job-name parsing were added.

Changes

Disruptive Longrunning Job Tier

Layer / File(s)	Summary
Job tier pattern rule and tests pkg/variantregistry/ocp.go, pkg/variantregistry/ocp_test.go	A new pattern in setJobTier classifies job names with -disruptive-longrunning as candidate. Two unit tests were added to validate parsing and feature-set variation.
Variant snapshot tier updates pkg/variantregistry/snapshot.yaml	Multiple variant entries in the snapshot have JobTier changed from hidden to candidate for affected disruptive-longrunning job variants.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 18 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Test Structure And Quality	❓ Inconclusive	Custom check specifies "Ginkgo test code" requirements, but PR adds standard Go table-driven tests using testify/assert (not Ginkgo). The check's applicability is ambiguous.	Clarify whether the Ginkgo-specific guidance applies to standard Go tests in this repo, or if the check only applies when actual Ginkgo tests are added.

✅ Passed checks (18 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: promoting disruptive long-running jobs to candidate tier for stabilization, which directly aligns with the changeset modifications.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	PR changes only add configuration data (job pattern string) and test cases with no error handling code. No ignored errors, panic calls, unwrapped errors, or nil dereferences introduced.
Sql Injection Prevention	✅ Passed	PR introduces no SQL injection vulnerabilities; changes are limited to job classification patterns and test data without adding unsafe SQL construction.
Excessive Css In React Should Use Styles	✅ Passed	PR modifies only Go and YAML configuration files; check targets React components with CSS, which are absent from these changes.
Test Coverage For New Features	✅ Passed	New functionality in ocp.go adding a -disruptive-longrunning pattern rule is adequately tested with two test cases in TestVariantSyncer verifying the rule assigns candidate tier to matching jobs.
Single Responsibility And Clear Naming	✅ Passed	Single job tier rule added within existing setJobTier method with clear naming and established conventions, introducing no generic names or structures violating single responsibility.
Stable And Deterministic Test Names	✅ Passed	Test names use static, hardcoded OpenShift job names without dynamic generation. The "1of2" suffix is a standard, fixed convention for Prow sharded jobs, not a generated suffix.
Microshift Test Compatibility	✅ Passed	No Ginkgo e2e tests were added in this PR. Changes are limited to variant registry configuration and standard Go unit tests, which are outside the scope of this MicroShift compatibility check.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds standard Go unit tests (t.Run), not Ginkgo e2e tests. Check only applies to Ginkgo tests, which are not present in this codebase.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only Sippy's CI job classification metadata (variant registry), not deployment manifests, operators, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	PR is for sippy CLI tool, not an OTE binary. Contains standard unit tests and configuration data, not OTE test suites. Check not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests. It only adds unit test cases to TestVariantSyncer using Go's standard testing package to test job name parsing. The check for Ginkgo tests is not applicable.
No-Weak-Crypto	✅ Passed	No weak crypto patterns detected. PR changes only modify job tier classification logic and test data, with no cryptographic code, weak algorithm usage, or insecure secret comparisons.
Container-Privileges	✅ Passed	PR modifies CI job classification logic in Go code and test data, not container/K8s manifests; no container security configurations present.
No-Sensitive-Data-In-Logs	✅ Passed	PR adds job tier classification rules and updates snapshot data with no new logging statements that could expose sensitive information like passwords, tokens, API keys, PII, or internal hostnames.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pkg/variantregistry/ocp.go`:
- Around line 800-802: Add a new table-driven test case in TestVariantSyncer
(pkg/variantregistry/ocp_test.go) that exercises the jobTierPatterns mapping for
disruptive longrunning jobs: include a job name containing
"-disruptive-longrunning" in the input jobs and assert that the resulting
VariantJobTier equals "candidate". Locate the test's cases slice, add an entry
with an appropriate job spec/name matching the pattern, run the test to ensure
the rule in jobTierPatterns ({[]string{"-disruptive-longrunning"}, "candidate"})
in pkg/variantregistry/ocp.go is covered and the assertion checks VariantJobTier
== "candidate".

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: af10f435-4ea2-411e-8879-9d21da0af736

📥 Commits

Reviewing files that changed from the base of the PR and between 2739439 and 72b8b34.

📒 Files selected for processing (2)

• pkg/variantregistry/ocp.go
• pkg/variantregistry/snapshot.yaml

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-ci]

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.