chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout) by charlesgong · Pull Request #426 · openshift/splunk-forwarder-operator

charlesgong · 2026-05-08T06:23:37Z

What type of PR is this?
boilerplate

What this PR does / why we need it?
This PR moves the changes introduced in boilerplate for Agentic SDLC Rollout into MVP for ocm-agent-operator.
Related BP MRs

Which Jira/Github issue(s) this PR fixes?
Part of Rollout for Agentic SDLC -

Lint -https://redhat.atlassian.net/browse/SREP-4482
Pre-Commit Hook - https://redhat.atlassian.net/browse/SREP-4486
CodeCov - https://redhat.atlassian.net/browse/SREP-4800

Special notes for your reviewer:
Pre-checks (if applicable):

Tested latest changes against a cluster
Ran make generate command locally to validate code changes
Included documentation changes with PR

openshift-ci-robot · 2026-05-08T06:23:44Z

@charlesgong: This pull request references SREP-4482 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

This pull request references SREP-4486 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

This pull request references SREP-4800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

What type of PR is this?
boilerplate

What this PR does / why we need it?
This PR moves the changes introduced in boilerplate for Agentic SDLC Rollout into MVP for ocm-agent-operator.
Related BP MRs

SREP-4482: Update golangci-lint configuration with enhanced linters boilerplate#716

SREP-4484: Enable Codecov Enforcement boilerplate#720

[SREP-4485] add pre-commit hooks to golang-osd-operator convention boilerplate#723

Which Jira/Github issue(s) this PR fixes?
Part of Rollout for Agentic SDLC -

Lint -https://redhat.atlassian.net/browse/SREP-4482

Pre-Commit Hook - https://redhat.atlassian.net/browse/SREP-4486

CodeCov - https://redhat.atlassian.net/browse/SREP-4800

Special notes for your reviewer:
Pre-checks (if applicable):

Tested latest changes against a cluster

Ran make generate command locally to validate code changes

Included documentation changes with PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-08T06:23:47Z

Warning

Rate limit exceeded

@charlesgong has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 51 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1814a91d-e429-4344-8369-27eae839a293

📥 Commits

Reviewing files that changed from the base of the PR and between 88595e1 and afe758c.

⛔ Files ignored due to path filters (8)

boilerplate/_data/backing-image-tag is excluded by !boilerplate/**
boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/.codecov.yml is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/golangci.yml is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/pre-commit-config.yaml is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/standard.mk is excluded by !boilerplate/**
boilerplate/openshift/golang-osd-operator/update is excluded by !boilerplate/**

📒 Files selected for processing (14)

.ci-operator.yaml
.claude/commands/pre-commit.md
.codecov.yml
.pre-commit-config.yaml
OWNERS_ALIASES
api/v1alpha1/groupversion_info.go
build/Dockerfile
build/Dockerfile.olm-registry
controllers/secret/secret_controller.go
controllers/splunkforwarder/splunkforwarder_controller.go
fips.go
pkg/kube/configmaps.go
pkg/kube/fixtures.go
pkg/kube/volumemounts_test.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov-commenter · 2026-05-08T06:28:00Z

Codecov Report

❌ Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.13%. Comparing base (88595e1) to head (afe758c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
controllers/secret/secret_controller.go	0.00%	5 Missing ⚠️
...lers/splunkforwarder/splunkforwarder_controller.go	81.81%	2 Missing ⚠️
fips.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   72.44%   72.13%   -0.31%     
==========================================
  Files          11       11              
  Lines         704      707       +3     
==========================================
  Hits          510      510              
- Misses        173      176       +3     
  Partials       21       21

Files with missing lines	Coverage Δ
pkg/kube/configmaps.go	`100.00% <100.00%> (ø)`
pkg/kube/fixtures.go	`90.00% <100.00%> (ø)`
fips.go	`0.00% <0.00%> (ø)`
...lers/splunkforwarder/splunkforwarder_controller.go	`45.00% <81.81%> (ø)`
controllers/secret/secret_controller.go	`38.88% <0.00%> (-1.70%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds .pre-commit-config.yaml with Tier 1 common hooks mirroring ci/prow/lint. Golden rules: SREP-4450 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

…c SDLC Rollout - Update golangci.yml with expanded linter set - Update standard.mk, pre-commit-config.yaml - Update .codecov.yml and OWNERS_ALIASES - Fix errcheck in fips.go (_, _ = fmt.Println) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

openshift-ci · 2026-05-14T00:33:11Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: charlesgong
Once this PR has been reviewed and has the lgtm label, please assign rafael-azevedo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dem4gus

/hold

Packages being installed on a user's system need to be pinned and locked.

This addresses a PR review comment expressing concern over automatically running pip install without explicit user consent.

openshift-ci · 2026-05-14T21:03:47Z

@charlesgong: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2026

openshift-ci Bot requested review from afreiberger and casey-williams-rh May 8, 2026 06:23

charlesgong force-pushed the SREP-4485 branch from 8b0e56a to 16d7a21 Compare May 10, 2026 22:33

charlesgong and others added 4 commits May 13, 2026 19:20

add: pre-commit hooks golden standard (SREP-4485)

d95c8eb

Adds .pre-commit-config.yaml with Tier 1 common hooks mirroring ci/prow/lint. Golden rules: SREP-4450 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

chore: boilerplate update with new: true golangci flag (SREP-4485)

c6e7a8e

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

fix: resolve linting errors for splunk-forwarder-operator

f5b3915

charlesgong force-pushed the SREP-4485 branch from 16d7a21 to f5b3915 Compare May 13, 2026 07:25

charlesgong added 2 commits May 14, 2026 12:19

Merge upstream/master

93d1c42

Fix prealloc lint error in configmaps.go

c54fca6

dem4gus suggested changes May 14, 2026

View reviewed changes

Comment thread .claude/commands/pre-commit.md Outdated

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2026

Update pre-commit AI command to not automatically install packages

afe758c

This addresses a PR review comment expressing concern over automatically running pip install without explicit user consent.

dem4gus mentioned this pull request May 18, 2026

chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout) #430

Open

charlesgong closed this May 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout)#426

chore(SREP-4482, SREP-4486, SREP-4800: Boilerplate Update for Agentic SDLC Rollout)#426
charlesgong wants to merge 7 commits into
openshift:masterfrom
charlesgong:SREP-4485

charlesgong commented May 8, 2026

Uh oh!

openshift-ci-robot commented May 8, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented May 8, 2026 •

edited

Loading

Rate limit exceeded

Uh oh!

codecov-commenter commented May 8, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented May 14, 2026

Uh oh!

dem4gus left a comment

Uh oh!

Uh oh!

openshift-ci Bot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

charlesgong commented May 8, 2026

Uh oh!

openshift-ci-robot commented May 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Uh oh!

codecov-commenter commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci Bot commented May 14, 2026

Uh oh!

dem4gus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-ci Bot commented May 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented May 8, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading

codecov-commenter commented May 8, 2026 •

edited

Loading