Bug 1833441: [release-4.4] Backport from master 05-13-2020 #199
Conversation
Currently, all WMCB logs are logged in stderr, including info level logs. This is because the zap package used redirects all logs to stderr by (default)[https://godoc.org/sigs.k8s.io/controller-runtime/pkg/log/zap#Options] This commit sets the info level logs to output to stdout. The logger should be used for errors, whereas the info and warning level messages should be output to stdout instead This is being done because the used version of `zap` package does not have an option to redirect the logs anywhere else. Moreeover, bumping its parent package, controller-runtime to newer versions that does have that option is not viable because it was simultaneously soft bumped to go1.13 and kube 1.16
WSU currently looks for success message in stderr after bootstrapper has been run. This commit changes the playbook to look for the same message in stdout instead.
This commit handles the AWS session creation error instead of panicing. The previous implementation used `Must()` which asserts that the wrapped function did not return an error and panics if it did. I removed that so that we can bubble up the returned error and handle it gracefully.
- Bring back downloading and installing oc in Dockerfile.tools. This is needed by the WSU playbook and was erroneously removed in #192. - Create Ansible tmp directory with user accessible permissions.
[ci] Step registry fixes
As of now, the ovn-kube network already comes with hybrid overlay enabled. So, we don't need to patch the network operator as the cluster comes up with hybrid overlay enabled. While patching we previously used to wait till all the nodes have hybrid-overlay specific annotations. In the new OVN world, the linux nodes won't have those annotations present, so the test was failing for us. This commit - Removes the test which fails if we have don't those annotations on master nodes - Removes patching the network operator object - Removes the test which checks for the WSU failure when hybrid overlay is not enabled
Bug 1823919: [ci] React to upstream kube-ovn changes
[wni] Don't panic on AWS session creation error
Creating a new pkgInfo struct required similar methods to populate its fields. Created an interface to generalize methods and making addition of multiple packages easier and non-redundant
This PR ensures that tests use kube node package with current k8s version Problem: wmcb e2e tests use kube-node packgage with hardcoded version. Solution: Use current kubernetes version to retrieve kubernetes node package for Windows. The corresponding SHA is retrieved using changelog.
[wmcb] Dynamically pick the kube-node package in the e2e tests
this commit changes the retrieval of backendPoolID to fetch the backendPoolID in a programmatic way. also, adds a method to disassociate ip address from NIC as the changes introduced in the PR broke the deleteVM function also, added tests to check the backendPoolID of the VMs created
[wni] Add programmatic retrieval of backendPoolID
This PR ensures that WNI uses inCLusterConfig when KUBECONFIG is not specified to create and delete instances.
Bug 1818026: Redirect WMCB info logs to stdout
[wni]Use pod permissions to create and delete instances
|
@aravindhp: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/approve cancel |
openshift-ci-robot
added
do-not-merge/hold
|
/approve if the tests pass. |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-wsu |
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ravisantoshgudimetla, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
aravindhp
changed the title
|
@aravindhp: All pull requests linked via external trackers have merged: . Bugzilla bug 1833441 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@aravindhp: Bugzilla bug 1833441 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
No description provided.