Drop OpenSlide Java#241
Merged
bgilbert merged 2 commits intoopenslide:mainfrom May 3, 2024
Merged
Conversation
Member
DCO signed off ✔️All commits have been signed off. You have certified to the terms of the Developer Certificate of Origin, version 1.1. In particular, you certify that this contribution has not been developed using information obtained under a non-disclosure agreement or other license terms that forbid you from contributing it under the GNU Lesser General Public License, version 2.1. |
This was referenced Apr 10, 2024
Merged
The next release will no longer have a platform-specific shared library, so there's no longer a need to build OpenSlide Java in openslide-bin. Drop it and all of its support code. Accept API version 3 of the Windows builder container and version 2 of the Linux builder container. After the next openslide-bin release, we can drop Java from the builder containers and bump to these API versions. Closes: openslide#239 Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
With OpenSlide Java gone, we now build only one dynamic library, so it's safe to set the filtering option globally. Signed-off-by: Benjamin Gilbert <bgilbert@cs.cmu.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The next OpenSlide Java release will no longer have a platform-specific shared library, so there's no longer a need to build OpenSlide Java in openslide-bin. Drop it and all of its support code.
Accept API version 3 of the Windows builder container and version 2 of the Linux builder container. After the next openslide-bin release, we can drop Java from the builder containers and bump to these API versions.
Closes: #239