[METRICS] Migrate topic collector to balancer, partitioiner#1765
Merged
chinghongfang merged 3 commits intoopensource4you:mainfrom May 23, 2023
Merged
[METRICS] Migrate topic collector to balancer, partitioiner#1765chinghongfang merged 3 commits intoopensource4you:mainfrom
chinghongfang merged 3 commits intoopensource4you:mainfrom
Conversation
garyparrot
reviewed
May 21, 2023
Collaborator
Author
|
感謝 @garyparrot 解釋,我誤會你的意思了,沒有理解這個用法的用意。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這隻 PR 將 topic collector 整合到
WebService(balancer) 以及StrictcostPartitioner中,讓兩者可以指定要使用哪一種 metric 收集方法。原來的作法是 "使用 JMX 直接收集"。現在的作法除了 "使用 JMX 直接收集" ,多了從 topic 收集 metric 的方法。
使用範例如下: