Skip to content

Add a new option -Wconstant #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add a new option -Wconstant #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cobj/warning-help.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
CB_WARNDEF (cb_warn_redefinition, "redefinition", 1,
N_("Warn incompatible redefinition of data items"))

CB_WARNDEF (cb_warn_constant, "constant", 1,
N_("Warn inconsistent constant"))

CB_WARNDEF (cb_warn_parentheses, "parentheses", 1,
N_("Warn lack of parentheses around AND within OR"))

Expand Down
1 change: 1 addition & 0 deletions tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ command_line_options_DEPENDENCIES = \
command-line-options.src/list-reserved.at \
command-line-options.src/assign_external.at \
command-line-options.src/Wredefinition.at \
command-line-options.src/Wconstant.at \
command-line-options.src/Wparentheses.at \
command-line-options.src/Wcolumn-overflow.at \
command-line-options.src/Wterminator.at \
Expand Down
1 change: 1 addition & 0 deletions tests/Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,7 @@ command_line_options_DEPENDENCIES = \
command-line-options.src/list-reserved.at \
command-line-options.src/assign_external.at \
command-line-options.src/Wredefinition.at \
command-line-options.src/Wconstant.at \
command-line-options.src/Wparentheses.at \
command-line-options.src/Wcolumn-overflow.at \
command-line-options.src/Wterminator.at \
Expand Down
1 change: 1 addition & 0 deletions tests/command-line-options.at
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ m4_include([list-reserved.at])
m4_include([assign_external.at])
m4_include([java-package.at])
m4_include([Wredefinition.at])
m4_include([Wconstant.at])
m4_include([Wparentheses.at])
m4_include([Wcolumn-overflow.at])
m4_include([Wterminator.at])
Expand Down
33 changes: 33 additions & 0 deletions tests/command-line-options.src/Wconstant.at
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
AT_SETUP([-Wcolumn-overflow])

AT_DATA([prog.cbl],
[ IDENTIFICATION DIVISION.
PROGRAM-ID. prog.
DATA DIVISION.
WORKING-STORAGE SECTION.
01 NUM PIC 9(7) COMP-5.
PROCEDURE DIVISION.
MOVE 10000000000 TO NUM.
])

AT_CHECK([cobj -Wconstant prog.cbl], [0], [],
[prog.cbl:7: Warning: Numeric literal exceeds data size
])

AT_DATA([prog.cbl],
[ IDENTIFICATION DIVISION.
PROGRAM-ID. prog.
DATA DIVISION.
WORKING-STORAGE SECTION.
01 NUM PIC 9.
PROCEDURE DIVISION.
MOVE -1 TO NUM.
])

AT_CHECK([cobj -Wconstant prog.cbl], [0], [],
[prog.cbl:7: Warning: Ignoring negative sign
])

AT_CHECK([${COBJ} --help | grep '\-Wconstant' > /dev/null], [0])

AT_CLEANUP