Handle Japanese characters in file identifiers correctly #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutaro-sakamoto
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #539, this pull request includes changes to improve the handling of Japanese characters in file names and adds a new test to verify the functionality. The most important changes include modifying the
to_cnamefunction to correctly handle multi-byte Japanese characters and adding a new test case for this functionality.Improvements to Japanese character handling:
cobj/tree.c: Modified theto_cnamefunction to correctly handle multi-byte Japanese characters by adjusting the loop to increment by two bytes for certain character ranges.Additions to test coverage:
tests/misc.src/file-handler-japanese.at: Added a new test case to verify that file names with Japanese characters are handled correctly.