Fix a bug of duplicate record keys of indexed files. #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to duplicate record keys in indexed files that was causing an infinite loop in new test executions. Key changes include:
- Introducing and resetting a new field (fetchKeyIndex) to manage duplicate key fetching.
- Overloading and modifying indexed_write_internal and indexed_delete_internal to incorporate handling for duplicate numbers.
- Adding logic to save and reuse duplicate numbers during write and delete operations.
Files not reviewed (1)
- tests/misc.src/record-key-duplicates-error.at: Language not supported
Comments suppressed due to low confidence (1)
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/file/CobolIndexedFile.java:604
- The condition 'i != this.fetchKeyIndex' may not correctly distinguish when to reuse a duplicate number. Please verify that fetchKeyIndex is set appropriately and that the condition accurately reflects the intended logic for duplicate handling.
if (dupNumbers == null || dupNumbers[i] < 0 || i != this.fetchKeyIndex) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
CobolIndexedFileclass in order to fix a bug of duplicate record keys.With previous version, executing the program in a new test causes an infinite loop.