Post-dry-run enhancements for Linux workshop#2
Merged
Conversation
* Update DB schema with last_step_completed * Put score server on DB server
JDeBo
reviewed
Jul 3, 2023
JDeBo
reviewed
Jul 3, 2023
ryapric
commented
Jul 4, 2023
ryapric
commented
Jul 4, 2023
ryapric
commented
Jul 4, 2023
ryapric
commented
Jul 4, 2023
…ecause I had the files on the host
JDeBo
reviewed
Jul 9, 2023
ryapric
commented
Jul 10, 2023
…corp/workshops into fix/bugs-from-dryrun
…shops into fix/bugs-from-dryrun
JDeBo
previously approved these changes
Jul 10, 2023
Collaborator
JDeBo
left a comment
JDeBo
left a comment
There was a problem hiding this comment.
Think this is looking good. I'm happy if you are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfixes, enhancements, and additions based on feedback from the dry-run group.
Tests were performed both automatically & manually, both locally (Vagrant) and remotely (AWS EC2).
Changes are:
make up-awsandmake provision-aws, respectively)wallcommands to post messages to users' terminals on step completions...uh, I added a lot more after we reviewed this, so.