feat: 添加登录图形验证码功能 by KadenZhang3321 · Pull Request #446 · opensourceways/app-cla-server

KadenZhang3321 · 2026-04-09T08:49:40Z

描述

为社区管理员登录增加图形验证码功能，防止暴力破解。当登录失败达到阈值次数后，下次登录需要输入验证码。

主要变更：

新增验证码服务 (signing/domain/captchaservice/, signing/infrastructure/captchaimpl/)
登录失败计数和验证码触发逻辑 (signing/domain/login.go, signing/domain/loginservice/service.go)
登录接口返回 need_captcha 和 retry_num 字段
验证码存储使用 Redis

变更类型

opensourceways-bot · 2026-04-09T08:49:50Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

opensourceways-bot · 2026-04-09T08:49:53Z

Linking Issue Notice

@KadenZhang3321 , the pull request must be linked to at least one issue.
If an issue has already been linked, but the needs-issue label remains, you can remove the label by commenting /check-issue .

gemini-code-assist

Code Review

This pull request introduces a graphic captcha system for corporation manager logins to protect against brute-force attacks, including new endpoints, domain logic, and a Redis-backed implementation. It also optimizes the corporation signing repository by implementing MongoDB index management, refactoring pagination queries to use a single aggregation pipeline, and adding a Redis-based cache decorator. Feedback highlights a regression in corporation name search logic, potential issues with error type preservation and Redis cache unmarshaling, and opportunities to improve logging consistency and goroutine safety.

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/repositoryimpl/corp_signing.go

 		} else {
-			// 按企业名称搜索（模糊匹配）
-			filter[childField(fieldCorp, fieldName)] = bson.M{"$regex": searchQuery, "$options": "i"}
+			filter[childField(fieldCorp, fieldName)] = searchQuery


The search logic for corporation names has been changed from a case-insensitive fuzzy search ($regex) to an exact match. This is a regression in functionality as users can no longer search for corporations by partial names. If performance was the concern, consider using a text index or keeping the regex with appropriate constraints.

Suggested change

filter[childField(fieldCorp, fieldName)] = searchQuery

filter[childField(fieldCorp, fieldName)] = bson.M{"$regex": searchQuery, "$options": "i"}

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/captchaimpl/impl.go

+	}
+
+	if !c.captcha.Verify(id, answer, true) {
+		return errors.New(string(errCaptchaInvalid))


Returning errors.New(string(errCaptchaInvalid)) creates a standard error that loses the ErrorCode() method defined on the domainError type. This will cause issues in the adapter layer where the error is checked against specific domain error codes. You should return the errCaptchaInvalid variable directly as it already implements the error interface and preserves the domain-specific metadata.

Suggested change

return errors.New(string(errCaptchaInvalid))

return errCaptchaInvalid

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/repositoryimpl/corp_signing_cache.go

+	var cached cachedCorpSigningPage
+	if err := c.cache.Get(key, &cached); err == nil {
+		return fromCache(cached), nil
+	}


The cache.Get method uses redisCli.Get(...).Scan(data) internally. Since cachedCorpSigningPage is a plain struct and does not implement redis.Scanner or encoding.BinaryUnmarshaler, the Scan call will fail to populate the struct from the JSON string stored in Redis. This results in a silent cache miss every time. You should retrieve the data as a string first and then use json.Unmarshal to populate the struct.

Suggested change

var cached cachedCorpSigningPage

if err := c.cache.Get(key, &cached); err == nil {

return fromCache(cached), nil

}

var payload string

if err := c.cache.Get(key, &payload); err == nil {

if json.Unmarshal([]byte(payload), &cached) == nil {

return fromCache(cached), nil

}

}

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/captchaimpl/impl.go

+	// if c.isTestEnv {
+	// 	id = uuid.New().String()
+	// 	if err = c.store.Set(id, c.testAnswer); err != nil {
+	// 		return
+	// 	}
+	// 	imageBase64 = "test_mode"
+	// 	return
+	// }


The test environment logic in the Generate method is commented out, rendering the isTestEnv and testAnswer parameters in NewCaptchaImpl effectively useless. If test mode support is required, this logic should be implemented and active.

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/repositoryimpl/corp_signing_cache.go

+import (
+	"encoding/json"
+	"fmt"
+	"log"


The standard log package is used here, but the rest of the project consistently uses github.com/beego/beego/v2/core/logs. Please switch to the project's preferred logging utility for consistency.

Suggested change

"log"

"github.com/beego/beego/v2/core/logs"

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/captchaimpl/redisdb.go

+
+	if clear {
+		// expire immediately
+		_ = s.dao.Expire(captchaKey(id), 0)


Using Expire(key, 0) to delete a key is less explicit and potentially less efficient than using the Del command. Since the Redis client already supports Del, you should add it to the local dao interface and use it here.

Suggested change

_ = s.dao.Expire(captchaKey(id), 0)

_ = s.dao.Del(captchaKey(id))

gemini-code-assist · 2026-04-09T08:54:02Z

signing/infrastructure/repositoryimpl/corp_signing_cache.go

+	}
+
+	// populate cache asynchronously so the caller is not blocked
+	go func() {


This goroutine lacks a recovery mechanism. If toCache or json.Marshal were to panic, it would cause the entire application to crash. It is safer to wrap the goroutine logic in a defer recover() block or use a centralized safe goroutine utility.

opensourceways-bot · 2026-04-09T09:04:39Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

KadenZhang3321 · 2026-04-09T09:09:35Z

@gemini review

gemini-code-assist

Code Review

This pull request implements graphic captcha verification for corporation manager logins to protect against brute-force attacks. It introduces a new CaptchaService, updates the login flow to require captcha after a threshold of failed attempts, and adds a Redis-based caching layer for corporation signing pages. Additionally, the MongoDB repository was refactored to use aggregation for more efficient pagination. Feedback includes removing commented-out code in the captcha implementation, escaping user input in regex searches to prevent injection, validating pagination parameters to avoid negative skip values, and verifying the impact of changing the admin field filter from nil to $exists: false.

gemini-code-assist · 2026-04-09T09:12:06Z

signing/infrastructure/captchaimpl/impl.go

+	// if c.isTestEnv {
+	// 	id = uuid.New().String()
+	// 	if err = c.store.Set(id, c.testAnswer); err != nil {
+	// 		return
+	// 	}
+	// 	imageBase64 = "test_mode"
+	// 	return
+	// }


The block of commented-out code should be removed to maintain code cleanliness. Additionally, the isTestEnv and testAnswer fields in the captchaImpl struct are currently unused, and the logic for a deterministic captcha in test environments is missing despite being passed in the constructor. Consider implementing the test mode logic or removing the unused parameters and fields.

gemini-code-assist · 2026-04-09T09:12:06Z

signing/infrastructure/repositoryimpl/corp_signing.go

 		} else {
-			// 按企业名称搜索（模糊匹配）
+			// 按企业名称搜索（模糊匹配，case-insensitive）
 			filter[childField(fieldCorp, fieldName)] = bson.M{"$regex": searchQuery, "$options": "i"}


Using an unescaped user-provided string directly in a MongoDB $regex query can lead to performance issues (such as ReDoS) or unexpected query results if the input contains special regex characters (e.g., .*). It is recommended to escape the searchQuery before incorporating it into the regex filter.

gemini-code-assist · 2026-04-09T09:12:06Z

signing/infrastructure/repositoryimpl/corp_signing.go

 		filter["$or"] = []bson.M{
 			{"admin.id": ""},
-			{"admin": nil},
+			{"admin": bson.M{"$exists": false}},


Changing the filter from {"admin": nil} to {"admin": {"$exists": false}} alters the query behavior. In MongoDB, a query for field: null matches both documents where the field is explicitly set to null and documents where the field is missing. The $exists: false operator only matches documents where the field is missing. If there are existing records where admin is null, they will be excluded from the results. Ensure this change is intentional and won't lead to data inconsistency.

gemini-code-assist · 2026-04-09T09:12:06Z

signing/infrastructure/repositoryimpl/corp_signing.go

+				bson.M{"$count": "n"},
+			},
+			"data": bson.A{
+				bson.M{"$skip": int64((intPage - 1) * intPageSize)},


The intPage and intPageSize parameters are used in a calculation for $skip without prior validation. If intPage is less than 1, the resulting skip value will be negative, which will cause the MongoDB aggregation to fail. It is safer to ensure the skip value is non-negative.

opensourceways-bot · 2026-04-09T09:24:49Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

opensourceways-bot · 2026-04-09T09:35:35Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T09:59:26Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T10:03:44Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T10:16:17Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T11:38:26Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

opensourceways-bot · 2026-04-09T12:16:46Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

opensourceways-bot · 2026-04-09T12:35:44Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

opensourceways-bot · 2026-04-09T12:38:26Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T12:38:32Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

opensourceways-bot · 2026-04-09T12:43:15Z

检查项	状态
敏感信息扫描	✅
安全编码扫描	❌
漏洞扫描	❌
Check代码检查	❌
开源license合规扫描	✅
UT测试覆盖率	❌
开发阶段设计文档检查	❌
流水线链接	点击跳转查看日志

- 添加登录图形验证码生成和验证接口 - 实现登录失败次数统计和验证码触发机制 - 登录成功后清除失败记录 - 修复 Code Review 相关问题

opensourceways-bot · 2026-04-10T02:08:11Z

CLA Signature Pass

KadenZhang3321, thanks for your pull request. All authors of the commits have signed the CLA. 👍

KadenZhang3321 · 2026-04-10T02:11:36Z

@gemini review

gemini-code-assist

Code Review

This pull request introduces a graphic captcha mechanism to protect against brute-force login attacks. It includes the necessary infrastructure for captcha generation and verification, updates the login flow to require captcha validation when a failure threshold is met, and adds relevant configuration and API endpoints. My review highlights a security concern regarding the fail-open behavior when the captcha requirement check fails, and suggests improvements for the captcha implementation's test mode and configuration flexibility.

gemini-code-assist · 2026-04-10T02:15:38Z

signing/app/user.go

+			return
+		}
+	} else if needed, checkErr := s.ls.NeedCaptcha(lid); checkErr != nil {
+		logs.Warn("failed to check captcha requirement, err: %s", checkErr.Error())


当前实现中，如果检查是否需要验证码的 s.ls.NeedCaptcha(lid) 调用失败，程序仅记录一条警告日志然后继续执行登录流程。这可能构成一个安全隐患，因为攻击者或许能通过让依赖的服务（如Redis）暂时不可用来绕过验证码。建议采用“失败即关闭”（fail-closed）的策略：当此检查失败时，应中断登录流程并返回错误，而不是继续尝试登录。

Suggested change

logs.Warn("failed to check captcha requirement, err: %s", checkErr.Error())

logs.Error("failed to check captcha requirement for %s, err: %s", lid, checkErr.Error())

err = checkErr

return

gemini-code-assist · 2026-04-10T02:15:39Z

signing/infrastructure/captchaimpl/impl.go

+func NewCaptchaImpl(d dao, cfg *Config, isTestEnv bool, testAnswer string) *captchaImpl {
+	store := &captchaStore{dao: d, expiry: cfg.expiry()}
+
+	driver := base64Captcha.NewDriverDigit(
+		80,  // height
+		240, // width
+		6,   // digit length
+		0.7, // noise level
+		80,  // background circle count
+	)
+
+	return &captchaImpl{
+		captcha:    base64Captcha.NewCaptcha(driver, store),
+		store:      store,
+		isTestEnv:  isTestEnv,
+		testAnswer: testAnswer,
+	}


此函数的实现有两处可以改进：

测试模式逻辑不完整：NewCaptchaImpl 函数接收 isTestEnv 和 testAnswer 参数，但它们在 Generate 方法中并未被使用（相关代码被注释掉了）。这使得测试模式实际上并未生效。建议完成该逻辑或移除未使用的参数和被注释的代码，以提高代码清晰度。

硬编码的验证码参数：NewDriverDigit 使用了硬编码的参数来配置验证码的样式和复杂度（如高度、宽度、长度等）。建议将这些参数移入 captchaimpl.Config 中，使其可通过配置文件进行调整，以增加灵活性。

opensourceways-bot added the opensourceways-cla/yes label Apr 9, 2026

opensourceways-bot added the needs-issue label Apr 9, 2026

gemini-code-assist bot reviewed Apr 9, 2026

View reviewed changes

opensourceways-bot added the stat/needs-squash label Apr 9, 2026

gemini-code-assist bot reviewed Apr 9, 2026

View reviewed changes

feat: 添加登录图形验证码功能

fa64fb1

- 添加登录图形验证码生成和验证接口 - 实现登录失败次数统计和验证码触发机制 - 登录成功后清除失败记录 - 修复 Code Review 相关问题

KadenZhang3321 force-pushed the feat_yangZhang branch from ffef0cd to fa64fb1 Compare April 10, 2026 02:08

opensourceways-bot removed the stat/needs-squash label Apr 10, 2026

KadenZhang3321 added the gate_check_pass label Apr 10, 2026

gemini-code-assist bot reviewed Apr 10, 2026

View reviewed changes

	filter[childField(fieldCorp, fieldName)] = searchQuery
	filter[childField(fieldCorp, fieldName)] = bson.M{"$regex": searchQuery, "$options": "i"}

	return errors.New(string(errCaptchaInvalid))
	return errCaptchaInvalid

	_ = s.dao.Expire(captchaKey(id), 0)
	_ = s.dao.Del(captchaKey(id))

-		logs.Warn("failed to check captcha requirement, err: %s", checkErr.Error())
+                logs.Error("failed to check captcha requirement for %s, err: %s", lid, checkErr.Error())
+                err = checkErr
+                return

Conversation

KadenZhang3321 commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

描述

相关 Issue

变更类型

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

opensourceways-bot commented Apr 9, 2026

Linking Issue Notice

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

KadenZhang3321 commented Apr 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

opensourceways-bot commented Apr 9, 2026

Uh oh!

opensourceways-bot commented Apr 9, 2026

Uh oh!

opensourceways-bot commented Apr 9, 2026

Uh oh!

opensourceways-bot commented Apr 9, 2026

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

opensourceways-bot commented Apr 9, 2026

CLA Signature Pass

Uh oh!

opensourceways-bot commented Apr 9, 2026

KadenZhang3321 commented Apr 9, 2026 •

edited

Loading