Skip to content

Conversation

@louis-openspace
Copy link

@louis-openspace louis-openspace commented Feb 21, 2024

Summary

This syncs the kotlin and java source and compile versions to 17. A RN 0.73 upgrade in Diana is causing this error message in this library when running Diana yarn android:

Execution failed for task ':react-native-background-upload:compileDebugKotlin'.
> 'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 1.8) jvm target compatibility should be set to the same Java version. Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

I've tried syncing to 18 but can't get that to work. I believe RN 0.73 recommends JDK 17 anyway

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've added Detox End-to-End Test(s)
  • I've created a snack to demonstrate the changes: LINK HERE

Copy link
Collaborator

@thomasttvo thomasttvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-openspace louis-openspace merged commit df00071 into master Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants