Conversation
brew
left a comment
There was a problem hiding this comment.
The babbage change still supports the single shared name syntax, as well as the new 2-string array, right? Looks good to me.
08677d5 to
c680a32
Compare
c680a32 to
1a3f2cf
Compare
|
@brew I added what we discussed (removal of os-api-loader). |
|
Cool, a couple of issues with old babbage fiscal imports. I can't run this at the moment because of an import error for babbage_fiscal: Similarly, tests are failing because of a failed import for babbage_fiscal: |
b9ea6f7 to
7d177af
Compare
c8fcc2e to
66b8df8
Compare
66b8df8 to
4ef014b
Compare
9ad0266 to
c7712cc
Compare
759fe24 to
24918f6
Compare
24918f6 to
ad0aadc
Compare
a466bd1 to
3cfa552
Compare
|
@brew tests are fixed now |
|
Great! I'm having a little trouble getting the tests to run locally, as there are some additional moving parts -- installing some system dependencies, running dpp and setting env var (e.g. |
aec8d29 to
5e8e6b2
Compare
5e8e6b2 to
7eabd28
Compare
This is a bit thin, as most of the modifications were done in babbage.
The main change there is to support a slight change to the babbage model syntax for supporting joins between two DB tables.
It used to support a simple
"join-column": "bla"syntax, allowing to join two db tables with the same name.The change in openspending/babbage@53e20b6 extended that to a 2-string array, detailing the names of the two columns in the two tables.