Skip to content

Fix NameError: import missing Sum_coll in load_data.py#327

Merged
tbaudier merged 2 commits intomasterfrom
copilot/fix-undefined-functions
Apr 20, 2026
Merged

Fix NameError: import missing Sum_coll in load_data.py#327
tbaudier merged 2 commits intomasterfrom
copilot/fix-undefined-functions

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

load_data_Comp_1D_old and load_data_Comp_1D_new in spyrit/misc/load_data.py call Sum_coll, which is defined in spyrit/misc/matrix_tools.py but was never imported — causing a NameError at runtime.

Change

  • spyrit/misc/load_data.py: Add missing import:
    from spyrit.misc.matrix_tools import Sum_coll
Original prompt

This section details on the original issue you should resolve

<issue_title>old code has undefined functions?</issue_title>
<issue_description>Some functions in spyrit.misc.load_data call an undefined function (Sum_coll), I'm guessing this is old code that was lost?

Image

</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI changed the title [WIP] Fix undefined functions in spyrit.misc.load_data Fix NameError: import missing Sum_coll in load_data.py Feb 24, 2026
Copilot AI requested a review from nducros February 24, 2026 08:57
Copilot AI and others added 2 commits April 20, 2026 10:20
Co-authored-by: nducros <22100601+nducros@users.noreply.github.com>
@tbaudier tbaudier force-pushed the copilot/fix-undefined-functions branch from 8a95d53 to 9938c0b Compare April 20, 2026 08:23
@tbaudier tbaudier marked this pull request as ready for review April 20, 2026 08:27
@tbaudier tbaudier merged commit 1783381 into master Apr 20, 2026
26 checks passed
@tbaudier tbaudier deleted the copilot/fix-undefined-functions branch April 20, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

old code has undefined functions?

3 participants