Make the SM2 group be the default group for SM2 algorithm#14684
Closed
t8m wants to merge 1 commit intoopenssl:masterfrom
Closed
Make the SM2 group be the default group for SM2 algorithm#14684t8m wants to merge 1 commit intoopenssl:masterfrom
t8m wants to merge 1 commit intoopenssl:masterfrom
Conversation
t8m
added
approval: review pending
levitte
approved these changes
Mar 25, 2021
levitte
added
approval: done
Member
|
My approval is subject to the CI succeeding, of course. But, I like what I see :-) |
mattcaswell
approved these changes
Mar 25, 2021
Member
mattcaswell
left a comment
mattcaswell
left a comment
There was a problem hiding this comment.
Approved assuming CIs pass
paulidale
approved these changes
Mar 25, 2021
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
added
approval: ready to merge
Member
Author
|
Merged to master. Thank you for the reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14481
Checklist