Fix OSSL_PARAM_allocate_from_text() to do sign extension#17104
Closed
levitte wants to merge 4 commits intoopenssl:masterfrom
Closed
Fix OSSL_PARAM_allocate_from_text() to do sign extension#17104levitte wants to merge 4 commits intoopenssl:masterfrom
levitte wants to merge 4 commits intoopenssl:masterfrom
Conversation
…size ints With arbitrary size ints, we get to know exactly how large the minimum buffer must be.
…mber When the parameter definition has the data type OSSL_PARAM_UNSIGNED_INTEGER, negative input values should not be accepted. Fixes openssl#17103
This is done for the data type OSSL_PARAM_INTEGER by checking if the most significant bit is set, and adding 8 to the number of buffer bits if that is the case. Everything else is already in place. Fixes openssl#17103
levitte
added
branch: master
|
github-actions
bot
added
the
severity: fips change
paulidale
added
approval: done
Contributor
|
This looks like a feature, so not for 3.0. Anyone think differently? |
Member
Author
|
Go look at #17103, then decide if you think this is a bugfix or an added feature. (I think it's a bugfix) |
paulidale
added
the
hold: discussion
Contributor
|
OTC question: bug fix or feature? |
Member
|
OTC:Bug fix |
mattcaswell
removed
the
hold: discussion
t8m
approved these changes
Nov 23, 2021
paulidale
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2021
…size ints With arbitrary size ints, we get to know exactly how large the minimum buffer must be. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17104)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2021
This is done for the data type OSSL_PARAM_INTEGER by checking if the most significant bit is set, and adding 8 to the number of buffer bits if that is the case. Everything else is already in place. Fixes #17103 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17104)
Member
Author
|
Merged master: 3.0: |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2021
This is done for the data type OSSL_PARAM_INTEGER by checking if the most significant bit is set, and adding 8 to the number of buffer bits if that is the case. Everything else is already in place. Fixes #17103 Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #17104) (cherry picked from commit 946bc0e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSSL_PARAM_allocate_from_text() doesn't do sign extension when it should.
See #17103.