Closed
Conversation
This is a false positive resulting from confusion over up_ref/free.
Another false positive tagged as such
Another reference counting false positive, now negated.
These are all false positives result from Coverity not understanding our up_ref and free pairing.
paulidale
added
branch: master
Member
|
Again I would not bother putting this into 3.0 branch. Also do we have an agreement that we want these ugly comments in code? |
t8m
added
the
triaged: documentation
Contributor
Author
|
I'll drop 3.0. I've false positived a lot of these "free" problems while dealing with Coverity. I'm sure some of these are returns. |
Member
|
Note: we can also log these with Synopsys as false positives we want to get fixed. |
Collaborator
|
This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago |
Contributor
Author
|
Ping. |
t8m
approved these changes
May 3, 2022
slontis
reviewed
May 3, 2022
Contributor
Author
|
Fixed. |
t8m
approved these changes
May 3, 2022
Contributor
Author
|
reping |
slontis
approved these changes
May 5, 2022
Member
slontis
left a comment
slontis
left a comment
There was a problem hiding this comment.
I also wish to know if 'we want these ugly comments in code?'..
Is this an OTC decision?
Contributor
Author
|
We decided to allow some but not a lot. |
t8m
added
approval: done
Contributor
Author
|
Merged, thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
May 6, 2022
This is a false positive resulting from confusion over up_ref/free. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #18014)
openssl-machine
pushed a commit
that referenced
this pull request
May 6, 2022
Another false positive tagged as such Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #18014)
openssl-machine
pushed a commit
that referenced
this pull request
May 6, 2022
Another reference counting false positive, now negated. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #18014)
openssl-machine
pushed a commit
that referenced
this pull request
May 6, 2022
These are all false positives result from Coverity not understanding our up_ref and free pairing. Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #18014)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All are false positives due to the up_ref/free setup we use. Added comments to hopefully quiet Coverity.