Skip to content

Include supported branches in coveralls#20383

Closed
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:coveralls+
Closed

Include supported branches in coveralls#20383
paulidale wants to merge 1 commit intoopenssl:masterfrom
paulidale:coveralls+

Conversation

@paulidale
Copy link
Copy Markdown
Contributor

The actions for the branches don't trigger.

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Applies to master branch approval: review pending This pull request needs review by a committer approval: otc review pending labels Feb 27, 2023
@paulidale paulidale self-assigned this Feb 27, 2023
@paulidale paulidale marked this pull request as draft February 27, 2023 00:09
@paulidale paulidale force-pushed the coveralls+ branch 8 times, most recently from 4656c72 to e740553 Compare February 27, 2023 03:20
@paulidale paulidale marked this pull request as ready for review February 27, 2023 04:18
@paulidale paulidale added the tests: exempted The PR is exempt from requirements for testing label Feb 27, 2023
Copy link
Copy Markdown
Member

@slontis slontis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if you have checked that there is output for all branched in coveralls

@paulidale
Copy link
Copy Markdown
Contributor Author

paulidale commented Feb 28, 2023

Builds were getting through before I changed the schedule to daily.

@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug and removed approval: review pending This pull request needs review by a committer labels Mar 1, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Mar 2, 2023
@openssl-machine
Copy link
Copy Markdown
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Copy Markdown
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Mar 2, 2023
@paulidale paulidale deleted the coveralls+ branch March 2, 2023 22:30
openssl-machine pushed a commit that referenced this pull request Mar 2, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #20383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants