Skip to content

Upgrade action/{upload,download}-artifact to v4#25920

Closed
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:upgrade-artifact-actions
Closed

Upgrade action/{upload,download}-artifact to v4#25920
levitte wants to merge 1 commit intoopenssl:masterfrom
levitte:upgrade-artifact-actions

Conversation

@levitte
Copy link
Copy Markdown
Member

@levitte levitte commented Nov 11, 2024

No description provided.

@levitte levitte added branch: master Applies to master branch approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing labels Nov 11, 2024
@levitte levitte force-pushed the upgrade-artifact-actions branch 2 times, most recently from ad3b59c to 17be040 Compare November 13, 2024 15:09
@t8m t8m added triaged: bug The issue/pr is/fixes a bug branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 and removed branch: 3.0 Applies to openssl-3.0 branch branch: 3.1 Applies to openssl-3.1 (EOL) branch: 3.2 Applies to openssl-3.2 (EOL) branch: 3.3 Applies to openssl-3.3 branch: 3.4 Applies to openssl-3.4 labels Nov 13, 2024
@t8m t8m closed this Nov 13, 2024
@t8m t8m reopened this Nov 13, 2024
@levitte
Copy link
Copy Markdown
Member Author

levitte commented Nov 25, 2024

Ping? Another approval would be nice...

@t8m t8m requested a review from a team November 26, 2024 07:34
Copy link
Copy Markdown
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 26, 2024
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 27, 2024
@openssl-machine
Copy link
Copy Markdown
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Nov 27, 2024
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from #25920)
@levitte
Copy link
Copy Markdown
Member Author

levitte commented Nov 27, 2024

Merged to master

eb73f30dae482fc96bcb2186475e744b1d6ca7da Upgrade action/{upload,download}-artifact to v4

@levitte
Copy link
Copy Markdown
Member Author

levitte commented Nov 27, 2024

Please also approve #25921, #25922, #25923, #25924, #25925

@levitte levitte closed this Nov 27, 2024
@levitte levitte deleted the upgrade-artifact-actions branch November 27, 2024 10:35
Sashan pushed a commit to Sashan/openssl that referenced this pull request Apr 23, 2025
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from openssl#25920)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants