Skip to content

Conversation

@JiangJias
Copy link
Contributor

Add check for the return value of BIO_new() to avoid potential NULL pointer dereference.

Fixes: 8a2ec00 ("apps/lib/http_server.{c,h}: clean up logging and move it to log.{c,h}")

Checklist
  • documentation is added or updated
  • tests are added or updated

Add check for the return value of BIO_new() to avoid potential NULL pointer dereference.

Fixes: 8a2ec00 ("apps/lib/http_server.{c,h}: clean up logging and move it to log.{c,h}")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
@fwh-dc fwh-dc added branch: master Applies to master branch approval: review pending This pull request needs review by a committer labels Nov 27, 2025
Copy link
Contributor

@fwh-dc fwh-dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8m t8m added triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Nov 28, 2025
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 28, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 29, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Dec 1, 2025

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Dec 1, 2025
openssl-machine pushed a commit that referenced this pull request Dec 1, 2025
Add check for the return value of BIO_new() to avoid potential NULL pointer dereference.

Fixes: 8a2ec00 ("apps/lib/http_server.{c,h}: clean up logging and move it to log.{c,h}")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>

Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #27918)
cxx194832 pushed a commit to cxx194832/openssl that referenced this pull request Dec 12, 2025
Add check for the return value of BIO_new() to avoid potential NULL pointer dereference.

Fixes: 8a2ec00 ("apps/lib/http_server.{c,h}: clean up logging and move it to log.{c,h}")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>

Reviewed-by: Frederik Wedel-Heinen <fwh.openssl@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#27918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants