Fixed !BN_copy() to BN_copy() == NULL to match openssl coding style#30573
Closed
ams4222 wants to merge 1 commit intoopenssl:masterfrom
Closed
Fixed !BN_copy() to BN_copy() == NULL to match openssl coding style#30573ams4222 wants to merge 1 commit intoopenssl:masterfrom
ams4222 wants to merge 1 commit intoopenssl:masterfrom
Conversation
Author
|
Tagging @bbbrumley for visibility! |
bbbrumley
reviewed
Mar 25, 2026
| goto end; | ||
|
|
||
| err = !BN_copy(A, a); | ||
| err = (BN_copy(A, a) == NULL); |
Contributor
There was a problem hiding this comment.
per coding style, the project likely prefers to drop the outer parenthesis here for readability
bbbrumley
reviewed
Mar 25, 2026
| goto end; | ||
| err = !BN_copy(B, b); | ||
| err = (BN_copy(B, b) == NULL); | ||
| if (err) |
Contributor
There was a problem hiding this comment.
NIT: per coding style, the project likely prefers to drop the outer parenthesis here for readability
Contributor
|
@ams4222 thank you for the PR! I went through all lines of the diff, only spotted those two nits. Good job 👍 Go ahead and bring this out of DRAFT status, and let's get feedback from the maintainers. (idk if they'll take a CLA waiver for this. Let's see.) |
openssl-machine
added
approval: review pending
ams4222
changed the title
Contributor
|
Thank you for the new commit! Don't worry about the CLA check failure, it'll fall off when the commits get squashed. LGTM, maintainers will chime in soon ;) |
esyr
previously approved these changes
Mar 26, 2026
github-actions
bot
added
the
severity: fips change
t8m
added
branch: master
Member
|
Although this is technically not copyrightable change, I think, we would still prefer if you could please sign CLA. |
t8m
previously approved these changes
Mar 26, 2026
openssl-machine
added
approval: done
Fixes openssl#30565 CLA: trivial
openssl-machine
added
approval: review pending
Author
|
Filled out the CLA |
esyr
approved these changes
Mar 26, 2026
t8m
approved these changes
Mar 26, 2026
openssl-machine
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 31, 2026
Per the coding style guide, Chapter 15, "Expressions"[1]:
Do not use implicit checks for numbers (not) being 0 or pointers
(not) being NULL.
Change occurrences of "!BN_copy(a, b)" checks to "BN_copy() == NULL"
to align with the coding style guide.
[1] https://www.openssl.org/policies/technical/coding-style.html#expressions
Resolves: #30565
CLA: trivial
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.foundation>
MergeDate: Tue Mar 31 00:10:41 2026
(Merged from #30573)
Member
|
Pushed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans code to align with the coding style guide OpenSSL provides.
The
BN_copyfunction returns aBIGNUM *. If there is an error, it returnsNULL.Before code cleanup:
if (!BN_copy(a, b))This is an implicit check that checks if
BIGNUM *isNULL. This goes against the coding style guidelines in Chapter 15.After code cleanup:
if (BN_copy(a, b) == NULL)This code change eliminates that implicit form to explicitly check if
BIGNUM *isNULL.All 99 instances of this implicit check have been resolved.
Fixes #30565