Skip test_quic_peer_addr_v6 in quicapitest when IPv6 is disabled by esyr · Pull Request #30580 · openssl/openssl

esyr · 2026-03-26T05:02:41Z

Addresses [1]. Also add the configuration with IPv6 disabled to the test matrix, patch up tests and TLSProxy to avoid using IPv6 loopback address when IPv6 is disabled, and clean up test/quicapitest.c a bit.

[1] #30574

nhorman · 2026-03-31T19:34:40Z

-    return init($class, $filter, $execute, $cert, $debug, 0);
+        $debug,
+        $use_IPv6) = @_;
+    return init($class, $filter, $execute, $cert, $debug, 0, $use_IPv6);


I'm not sure why you're passing in the result of have_IPv6() here. The TLSProxy code already decides weather to use ipv6 or not based on weather or not it is able to create an AF_INET6 socket. It seems like thats what we should be fixing here, though it doesn't appear as anything is wrong with it.

I'm also not sure why the TLSProxy code is being changed here, as the reported issue just references the quicapi tests.

I'm also not sure why the TLSProxy code is being changed here, as the reported issue just references the quicapi tests.

Because TLSProxy has no notion of OPENSSL_USE_IPV6=0, and make test after ./config -DOPENSSL_IPV6=0 blows up thusly:

Test Summary Report ------------------- 75-test_quicapi.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 70-test_sslrecords.t (Wstat: 1024 (exited 4) Tests: 34 Failed: 4) Failed tests: 19, 22-23, 34 Non-zero exit status: 4

70-test_sslrecords.t fails only on DTLS tests, but that has revealed that TLSProxy doesn't respect library build configuration in this aspect.

It seems like thats what we should be fixing here, though it doesn't appear as anything is wrong with it.

For that, TLSProxy needs to obtain knowledge from configdata, and that requires importing of OpenSSL::Util package into TLSProxy, something that the latter doesn't do so far. I've opted out for following the debug option's example here, which could have also obtained from the environment, but is explicitly passed instead.

t8m · 2026-04-02T09:58:06Z

          no-ui,
-          no-quic
+          no-quic,
+          -DOPENSSL_USE_IPV6=0


Please move this to run-checker-merge or run-checker-daily or select another thing (I'd suggest no-ui or no-legacy.) to be moved if you think this is more important. We need to keep the number of CI jobs run on PR limited.

I'm in favor of dropping no-ui.

t8m · 2026-04-02T09:59:33Z

    TPARAM_OP_MUTATE
 };

+/* clang-format off */


Why is this needed?

It butchered alignment in TPARAM_CHECK_* array, which became difficult to read.

t8m · 2026-04-02T10:00:13Z

 static const unsigned char malformed_preferred_addr_2[42] = {
-    0x0d,
-    0x28, /* too short */
+    0x0d, 0x28, /* too short */


This does not need clang-format-off. Just drop the trailing comma.

Not a great fan of commas polluting diffs on array changes. Also, from personal experience, absence of trailing commas blows up nicely when shuffling arrays of strings, not that it is necessarily applicable here, however.

Restricted the usage to TPARAM_CHECK_* parts only.

Define and add the test only if OPENSSL_USE_IPV6 is set to 1. Resolves: openssl#30574 Fixes: beec4e1 "Add SSL_get_peer_addr() function to query peer address for QUIC" Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Add a parameter to TLSProxy::Proxy->new() and TLSProxy::Proxy->new_dtls() that indicates IPv6 usage preference and pass have_IPv6() to it, so IPv6 usage is avoided when it is disabled. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Add -DOPENSSL_USE_IPV6=0 to run-checker-ci.yml and move no-ui to run-checker-merge. References: openssl#30574 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

Shut off clang-format, as it is incapable of formatting arrays properly, and just mangles everything instead. Also, while at it, drop the trailing commas from TPARAM_CHECK_* definitions, as they are pretty confusing. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

openssl-machine · 2026-04-09T12:01:02Z

This pull request is ready to merge

Define and add the test only if OPENSSL_USE_IPV6 is set to 1. Resolves: #30574 Fixes: beec4e1 "Add SSL_get_peer_addr() function to query peer address for QUIC" Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:45:31 2026 (Merged from #30580)

Add a parameter to TLSProxy::Proxy->new() and TLSProxy::Proxy->new_dtls() that indicates IPv6 usage preference and pass have_IPv6() to it, so IPv6 usage is avoided when it is disabled. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:45:33 2026 (Merged from #30580)

Add -DOPENSSL_USE_IPV6=0 to run-checker-ci.yml and move no-ui to run-checker-merge. References: #30574 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:45:34 2026 (Merged from #30580)

Shut off clang-format, as it is incapable of formatting arrays properly, and just mangles everything instead. Also, while at it, drop the trailing commas from TPARAM_CHECK_* definitions, as they are pretty confusing. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:45:37 2026 (Merged from #30580)

jogme · 2026-04-15T12:46:26Z

Merged to master and 4.0. Thank you!

Define and add the test only if OPENSSL_USE_IPV6 is set to 1. Resolves: #30574 Fixes: beec4e1 "Add SSL_get_peer_addr() function to query peer address for QUIC" Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:46:04 2026 (Merged from #30580)

Add a parameter to TLSProxy::Proxy->new() and TLSProxy::Proxy->new_dtls() that indicates IPv6 usage preference and pass have_IPv6() to it, so IPv6 usage is avoided when it is disabled. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:46:06 2026 (Merged from #30580)

Add -DOPENSSL_USE_IPV6=0 to run-checker-ci.yml and move no-ui to run-checker-merge. References: #30574 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:46:07 2026 (Merged from #30580)

Shut off clang-format, as it is incapable of formatting arrays properly, and just mangles everything instead. Also, while at it, drop the trailing commas from TPARAM_CHECK_* definitions, as they are pretty confusing. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> MergeDate: Wed Apr 15 12:46:09 2026 (Merged from #30580)

esyr requested a review from quarckster as a code owner March 26, 2026 05:02

esyr added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 4.0 Applies to openssl-4.0 labels Mar 26, 2026

esyr changed the title ~~Skip test_quic_peer_addr_v6 quicapitest when IPv6 is disabled~~ Skip test_quic_peer_addr_v6 in quicapitest when IPv6 is disabled Mar 26, 2026

esyr force-pushed the esyr/quicapitest-no-ipv6 branch 2 times, most recently from c250c16 to 225c61f Compare March 26, 2026 05:12

nhorman reviewed Mar 31, 2026

View reviewed changes

esyr requested a review from Sashan April 2, 2026 09:09

t8m requested changes Apr 2, 2026

View reviewed changes

esyr added 4 commits April 2, 2026 12:34

run-checker-ci.yml, run-checker-merge: add -DOPENSSL_USE_IPV6=0

96a2fb3

Add -DOPENSSL_USE_IPV6=0 to run-checker-ci.yml and move no-ui to run-checker-merge. References: openssl#30574 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>

esyr force-pushed the esyr/quicapitest-no-ipv6 branch from 225c61f to be23210 Compare April 2, 2026 10:35

esyr requested review from nhorman and t8m April 4, 2026 19:08

nhorman approved these changes Apr 7, 2026

View reviewed changes

npajkovsky approved these changes Apr 8, 2026

View reviewed changes

openssl-machine added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 8, 2026

t8m approved these changes Apr 8, 2026

View reviewed changes

t8m added the tests: present The PR has suitable tests present label Apr 8, 2026

openssl-machine removed the approval: done This pull request has the required number of approvals label Apr 9, 2026

openssl-machine added the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 9, 2026

esyr added the hold: merge after release This pull request must not be merged until after the release from the merge branch is done label Apr 13, 2026

jogme removed the hold: merge after release This pull request must not be merged until after the release from the merge branch is done label Apr 15, 2026

jogme closed this Apr 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skip test_quic_peer_addr_v6 in quicapitest when IPv6 is disabled#30580

Skip test_quic_peer_addr_v6 in quicapitest when IPv6 is disabled#30580
esyr wants to merge 4 commits into
openssl:masterfrom
esyr:esyr/quicapitest-no-ipv6

esyr commented Mar 26, 2026

Uh oh!

nhorman Mar 31, 2026

Uh oh!

esyr Apr 1, 2026

Uh oh!

t8m Apr 2, 2026

Uh oh!

esyr Apr 2, 2026

Uh oh!

t8m Apr 2, 2026

Uh oh!

esyr Apr 2, 2026 •

edited

Loading

Uh oh!

t8m Apr 2, 2026

Uh oh!

esyr Apr 2, 2026 •

edited

Loading

Uh oh!

esyr Apr 2, 2026

Uh oh!

openssl-machine commented Apr 9, 2026

Uh oh!

jogme commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

esyr commented Mar 26, 2026

Uh oh!

nhorman Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

esyr Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

t8m Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

esyr Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

t8m Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

esyr Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

t8m Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

esyr Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

esyr Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

openssl-machine commented Apr 9, 2026

Uh oh!

jogme commented Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

esyr Apr 2, 2026 •

edited

Loading

esyr Apr 2, 2026 •

edited

Loading