Document X509V3_EXT_print API const change in manual page#30595
Closed
schwabe wants to merge 1 commit into
Closed
Conversation
Commit e75bd84 made the ext argument of 509V3_EXT_print const but did not update the man page to match the implementation. Signed-off-by: Arne Schwabe <arne@rfc2549.org>
t8m
added
branch: master
t8m
approved these changes
Mar 27, 2026
esyr
approved these changes
Mar 27, 2026
openssl-machine
added
approval: done
Member
|
It seems that commit e75bd84 has dropped the ball in terms of documenting the changes, more updates are needed. |
esyr
added a commit
to esyr/openssl
that referenced
this pull request
Mar 27, 2026
… const Update the documentation to include that added const qualifiers to the arguments of X509_EXTENSION_get_object(), X509_EXTENSION_get_data(), and X509v3_add_ext(). References: openssl#30595 Complements: e75bd84 "Constify X509_get_ext() and friends.." Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Collaborator
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
esyr
added
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Mar 31, 2026
… const Update the documentation to include that added const qualifiers to the arguments of X509_EXTENSION_get_object(), X509_EXTENSION_get_data(), and X509v3_add_ext(). References: #30595 Complements: e75bd84 "Constify X509_get_ext() and friends.." Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> MergeDate: Tue Mar 31 00:47:35 2026 (Merged from #30601)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 31, 2026
… const Update the documentation to include that added const qualifiers to the arguments of X509_EXTENSION_get_object(), X509_EXTENSION_get_data(), and X509v3_add_ext(). References: #30595 Complements: e75bd84 "Constify X509_get_ext() and friends.." Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> MergeDate: Tue Mar 31 00:47:35 2026 (Merged from #30601) (cherry picked from commit 0d5553f)
openssl-machine
pushed a commit
that referenced
this pull request
Mar 31, 2026
Commit e75bd84 made the ext argument of 509V3_EXT_print const but did not update the man page to match the implementation. Complements: e75bd84 "Constify X509_get_ext() and friends.." Signed-off-by: Arne Schwabe <arne@rfc2549.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> MergeDate: Tue Mar 31 01:01:51 2026 (Merged from #30595)
Member
|
Pushed to |
openssl-machine
pushed a commit
that referenced
this pull request
Mar 31, 2026
Commit e75bd84 made the ext argument of 509V3_EXT_print const but did not update the man page to match the implementation. Complements: e75bd84 "Constify X509_get_ext() and friends.." Signed-off-by: Arne Schwabe <arne@rfc2549.org> Reviewed-by: Tomas Mraz <tomas@openssl.foundation> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> MergeDate: Tue Mar 31 01:01:51 2026 (Merged from #30595) (cherry picked from commit dfe7d50)
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit e75bd84 made the ext argument of 509V3_EXT_print const but did not update the man page to match the implementation.
This implements only the missing man page change for OpenSSL 4.0 as requested in #30572
Checklist