Fix the no-deprecated symbol CI test#31016
Closed
bob-beck wants to merge 1 commit into
Closed
Conversation
bob-beck
requested review from
esyr,
jogme,
mattcaswell,
nhorman and
npajkovsky
The symbol presence test fails for NO_DEPRECATED builds if you use modern CPP practices for definitions. This is the result of my accepting that doing so will be as PTSD inducing as walking into my parents bedroom at an inopportune time, and fixing it. Better me who has less time left to live with the mental trauma than a younger developer.
bob-beck
force-pushed
the
fix-no-deprecated-test
branch
from
72eb68f to
c586830
Compare
openssl-machine
added
the
approval: review pending
2 tasks
npajkovsky
approved these changes
Apr 29, 2026
npajkovsky
left a comment
npajkovsky
left a comment
There was a problem hiding this comment.
That's eyebrow-raising, what we do...
openssl-machine
added
the
approval: done
github-project-automation
Bot
moved this from Waiting Review
to Waiting Merge
in Development Board
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
|
Merged to master. Thank you for your sacrifice! 🪦 |
github-project-automation
Bot
moved this from Waiting Merge
to Done
in Development Board
openssl-machine
pushed a commit
that referenced
this pull request
May 1, 2026
The symbol presence test fails for NO_DEPRECATED builds if you use modern CPP practices for definitions. This is the result of my accepting that doing so will be as PTSD inducing as walking into my parents bedroom at an inopportune time, and fixing it. Better me who has less time left to live with the mental trauma than a younger developer. Reviewed-by: Nikola Pajkovsky <nikolap@openssl.org> Reviewed-by: Norbert Pocs <norbertp@openssl.org> MergeDate: Fri May 1 11:01:46 2026 (Merged from #31016)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol presence test fails for NO_DEPRECATED builds if you use modern CPP practices for definitions.
This is because the perl preprocessing of the preprocessor input doesn't understand "#if !defined", which I suspected
but was avoiding figuring out. This is the result of my accepting that doing so will be as PTSD inducing as walking into my parents bedroom at an inopportune time, and fixing it. Better me who has less time left to live with the mental trauma than a younger developer.
Checklist