Decouple BIGNUM from OSSL_FN in the design doc#31847
Open
levitte wants to merge 1 commit into
Open
Conversation
Reflect the decision (openssl/project#2018) to stop wrapping BN_ operator functions around OSSL_FN_ operator functions: BN functions keep their current behaviour, and BIGNUM<->OSSL_FN conversion happens at top-level crypto call sites. Also drop the "Dropping top from BIGNUM" section and the stale TODO(FIXNUM) field-removal comments, since `top` stays in BIGNUM. Refs: openssl/project#2019 Assisted-by: Pi:z-ai/glm-5.2 Signed-off-by: Richard Levitte <levitte@openssl.foundation>
levitte
force-pushed
the
feature/ossl_fn+2018+design-doc
branch
from
45a76ed to
a14fb5d
Compare
openssl-machine
added
the
approval: review pending
levitte
added
branch: feature
levitte
requested review from
beldmit,
igus68,
kroeckx,
mattcaswell,
t8m and
tomato42
github-project-automation
Bot
moved this from Waiting Review
to Done
in Development Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
doc/designs/fixed-size-large-numbers.mdto reflect thedecision in openssl/project#2018 to stop wrapping
BN_operatorfunctions around
OSSL_FN_operator functions:BNfunctions keep their current behaviour (size manipulation isfine within the
BN"bubble").BIGNUM↔OSSL_FNconversion now happens at top-level crypto callsites, where the embedded
OSSL_FNis acquired and passed toOSSL_FNfunctions; theOSSL_FNsize is immutable for theduration of those calls.
Wrapping an OSSL_FN function with a BIGNUM functionsection (the
BN_addwrapper example) and related prose.Dropping top from BIGNUMsection and the associatedtiming claim, since
topwill stay inBIGNUM.TODO(FIXNUM)field-removal comments incrypto/bn(top/d/dmax/negare not going away).Doc-only by intent; the actual removal of existing
BN_*wrapper codeis tracked separately under openssl/project#2020.
Parent decision: openssl/project#2018
Sub-issue: openssl/project#2019