Closed
Conversation
Use SSL_set1_dnsname if available. If not, fallback to SSL_set1_host
Contributor
|
#80 already adds this |
jogme
approved these changes
Feb 27, 2026
Sashan
approved these changes
Feb 27, 2026
Contributor
Sashan
left a comment
Sashan
left a comment
There was a problem hiding this comment.
I like it. with or without nit being addressed. thanks.
Contributor
Author
|
The CI failure is unrelated, and trying to re-run the CI job doesn't fix it |
jogme
pushed a commit
that referenced
this pull request
Feb 27, 2026
Use SSL_set1_dnsname if available. If not, fallback to SSL_set1_host Reviewed-by: Saša Nedvědický <sashan@openssl.org> Reviewed-by: Norbert Pocs <norbertp@openssl.org> MergeDate: Fri Feb 27 17:55:27 2026 (Merged from #82)
Contributor
|
That's fine. Merged manually. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SSL_set1_dnsname if available. If not, fallback to SSL_set1_host
Fixes openssl/project#1882