fix: Stop swagger-ui redirect loop, split main()#899
Merged
Conversation
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
| Branch | binary-optimize |
| Testbed | ubuntu-latest |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Upper Boundary (Limit %) |
|---|---|---|---|---|
| Raft_1Node_Latency/read/1node | Latency microseconds (µs) | 📈 plot 🚷 threshold 🚨 alert (🔔) | 45.38 µs(+473.59%)Baseline: 7.91 µs | 45.07 µs (100.67%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 152,220.00 ns(-46.16%)Baseline: 282,750.36 ns | 1,686,273.19 ns (9.03%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 168,490.00 ns(-27.81%)Baseline: 233,398.47 ns | 983,564.80 ns (17.13%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 121.44 ns(+0.97%)Baseline: 120.27 ns | 141.84 ns (85.61%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 110.14 ns(+0.40%)Baseline: 109.70 ns | 129.32 ns (85.17%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 192.09 ns(-0.38%)Baseline: 192.82 ns | 230.80 ns (83.23%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 112.00 ns(+2.27%)Baseline: 109.51 ns | 128.70 ns (87.02%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 201.90 ns(+4.68%)Baseline: 192.87 ns | 233.96 ns (86.30%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 160.39 ns(-0.09%)Baseline: 160.54 ns | 195.75 ns (81.94%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 275.09 ns(+5.36%)Baseline: 261.10 ns | 322.80 ns (85.22%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 154.44 ns(-3.09%)Baseline: 159.37 ns | 193.88 ns (79.66%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 121.67 ns(+4.49%)Baseline: 116.45 ns | 138.79 ns (87.66%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 197.46 ns(-3.81%)Baseline: 205.28 ns | 271.75 ns (72.66%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 206.79 ns(+0.97%)Baseline: 204.80 ns | 247.03 ns (83.71%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 291.44 ns(+6.51%)Baseline: 273.63 ns | 338.80 ns (86.02%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,536,900.00 ns(-9.76%)Baseline: 2,811,277.66 ns | 5,725,442.99 ns (44.31%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold 🚨 view alert (🔔) | 45,375.00 ns(+473.59%)Baseline: 7,910.76 ns | 45,071.94 ns (100.67%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 385,320.00 ns(-29.48%)Baseline: 546,409.69 ns | 2,294,915.48 ns (16.79%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 460,610.00 ns(-18.64%)Baseline: 566,146.09 ns | 2,127,959.36 ns (21.65%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 108,380.00 ns(+3.18%)Baseline: 105,036.77 ns | 161,656.81 ns (67.04%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,457.60 ns(+5.23%)Baseline: 1,385.20 ns | 1,623.34 ns (89.79%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.33 ns(+4.65%)Baseline: 0.32 ns | 0.37 ns (89.48%) |
| get_db | 📈 view plot 🚷 view threshold | 0.33 ns(+5.10%)Baseline: 0.32 ns | 0.37 ns (89.98%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 145.27 ns(+0.34%)Baseline: 144.77 ns | 180.36 ns (80.55%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.45 ns(-5.45%)Baseline: 4.71 ns | 8.75 ns (50.90%) |
NormalizePathLayer wrapped SwaggerUi along with the API router, so trimming the trailing slash raced SwaggerUi's own "/swagger-ui" -> "/swagger-ui/" redirect into an infinite loop (utoipa#1467). SwaggerUi is now mounted via fallback_service outside the normalized service. - extract main() into init_tracing, init_audit, subscribe_event_hooks, build_router, start_raft, spawn_opa_subprocess, and per-interface listener functions - wrap the audit KEK in SecretBox so it zeroizes on drop - return Result from spawn_internal_listener instead of logging and continuing on a non-SPIFFE internal-interface misconfiguration - replace axum::serve(...).unwrap() on the public listener with the same log-and-cancel pattern used by the other listeners - fix extract_provider_name's &Box<dyn Error> clippy lint, allow get_domain's currently-unused-but-tested dead code - add regression tests for the swagger-ui fix, trailing-slash normalization, and audit KEK generate/reuse/reject-bad-length Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NormalizePathLayer wrapped SwaggerUi along with the API router, so
trimming the trailing slash raced SwaggerUi's own "/swagger-ui" ->
"/swagger-ui/" redirect into an infinite loop (utoipa#1467). SwaggerUi
is now mounted via fallback_service outside the normalized service.
build_router, start_raft, spawn_opa_subprocess, and per-interface
listener functions
continuing on a non-SPIFFE internal-interface misconfiguration
same log-and-cancel pattern used by the other listeners
get_domain's currently-unused-but-tested dead code
normalization, and audit KEK generate/reuse/reject-bad-length
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com