fix(credential): Enforce Null Key check at service startup#913
Merged
Conversation
87a8430 to
55b2a1e
Compare
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
|
FernetKeyRepository::load() already detected the well-known Null Key, but only lazily on first credential access. Add check_startup_null_key(), wired into the keystone binary's main() right after config load, so a misconfigured credential key repository refuses to start immediately instead of failing on the first request. Assisted-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
55b2a1e to
4b8378c
Compare
|
| Branch | claude/adr-0019-keystone-compat-nfzp1z |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 132,770.00 ns(-55.98%)Baseline: 301,582.44 ns | 1,713,833.07 ns (7.75%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 141,760.00 ns(-44.18%)Baseline: 253,956.11 ns | 1,029,650.44 ns (13.77%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 123.37 ns(+1.43%)Baseline: 121.63 ns | 146.36 ns (84.29%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 112.60 ns(+2.35%)Baseline: 110.01 ns | 131.59 ns (85.57%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 199.04 ns(+1.82%)Baseline: 195.48 ns | 239.31 ns (83.17%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 112.36 ns(+2.21%)Baseline: 109.93 ns | 131.22 ns (85.63%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 198.93 ns(+3.34%)Baseline: 192.51 ns | 234.66 ns (84.77%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 157.64 ns(-1.29%)Baseline: 159.70 ns | 197.85 ns (79.68%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 287.24 ns(+7.07%)Baseline: 268.26 ns | 333.76 ns (86.06%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 163.50 ns(+2.65%)Baseline: 159.28 ns | 196.43 ns (83.24%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 134.02 ns(+15.66%)Baseline: 115.87 ns | 140.72 ns (95.24%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 208.84 ns(+2.87%)Baseline: 203.02 ns | 267.74 ns (78.00%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 201.28 ns(-1.76%)Baseline: 204.88 ns | 253.54 ns (79.39%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 292.25 ns(+3.96%)Baseline: 281.12 ns | 352.52 ns (82.90%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,593,900.00 ns(-4.71%)Baseline: 2,721,999.84 ns | 6,217,938.85 ns (41.72%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 45,333.00 ns(+129.05%)Baseline: 19,791.85 ns | 68,413.05 ns (66.26%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 373,950.00 ns(-35.04%)Baseline: 575,673.59 ns | 2,321,986.17 ns (16.10%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 395,570.00 ns(-33.73%)Baseline: 596,915.78 ns | 2,150,774.08 ns (18.39%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 113,520.00 ns(+2.45%)Baseline: 110,804.56 ns | 162,475.18 ns (69.87%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,446.80 ns(+4.75%)Baseline: 1,381.14 ns | 1,637.20 ns (88.37%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(-0.26%)Baseline: 0.31 ns | 0.36 ns (85.78%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(-0.28%)Baseline: 0.31 ns | 0.36 ns (85.86%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 141.76 ns(-1.27%)Baseline: 143.58 ns | 181.18 ns (78.24%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.38 ns(-9.25%)Baseline: 4.83 ns | 9.76 ns (44.91%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FernetKeyRepository::load() already detected the well-known Null Key,
but only lazily on first credential access. Add
check_startup_null_key(), wired into the keystone binary's main() right
after config load, so a misconfigured credential key repository refuses
to start immediately instead of failing on the first request.