Skip to content

[dnm]: Roles fix test#3904

Closed
michburk wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
michburk:roles-fix-test
Closed

[dnm]: Roles fix test#3904
michburk wants to merge 3 commits intoopenstack-k8s-operators:mainfrom
michburk:roles-fix-test

Conversation

@michburk
Copy link
Copy Markdown
Contributor

@michburk michburk commented May 6, 2026

No description provided.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign michburk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michburk
Copy link
Copy Markdown
Contributor Author

michburk commented May 6, 2026

Check if commit message contains role prefix / verify-prefix (pull_request)
failed as expected

@evallesp @claude @michburk
Update check-role-prefix script
43fdf19 
Now the script can handle a PR containing more than
one commit where each commit might update or not
roles.

Now instead of checking last commit, it checks the whole
commits modified and iterates over them.

Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Enrique Vallespi Gil <evallesp@redhat.com>
@michburk
Copy link
Copy Markdown
Contributor Author

michburk commented May 6, 2026

Check if commit message contains role prefix / verify-prefix (pull_request)
passed as expected 🎉
going to do one more test with the wrong prefix

michburk added 2 commits May 6, 2026 11:14
@michburk
[wrong_prefix]: Add a comment
be055a0 
Adding a comment here this should work without issue

Signed-off-by: Michael Burke <michburk@redhat.com>
@michburk
[libvirt_manager]: Insert a comment
2f5d165 
here is some suitably long text in the git commit body :)

Signed-off-by: Michael Burke <michburk@redhat.com>
@michburk
Copy link
Copy Markdown
Contributor Author

michburk commented May 6, 2026

worked wonderfully 💯

@michburk michburk closed this May 6, 2026
@michburk michburk mentioned this pull request May 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michburk @evallesp