Skip to content

Prepare repository for consumption.#34

Merged
cjeanner merged 12 commits intomainfrom
cleaning
Mar 5, 2026
Merged

Prepare repository for consumption.#34
cjeanner merged 12 commits intomainfrom
cleaning

Conversation

@cjeanner
Copy link
Copy Markdown
Collaborator

No description provided.

* Clean everything that isn't used anymore.
* Rework tree to expose a flatter content.
* Start proposing an update for the README content.
Add some more content for the embedded documentation.
This also introduce a small example showing how to consume the
components.
This allows to then refer to each component separately, providing a nice
way to avoid code duplication.
This shows how to import the remote `architecture` component to deploy
dependencies, such as metalLB, cert-manager and nmstate.
This provides an example of potential structure and how to compose
controlplane and dataplane.
Comment thread example/controlplane/kustomization.yaml
@pinikomarov
Copy link
Copy Markdown

Overall looks good to me

Copy link
Copy Markdown

@aharivel aharivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner and more composable than the old hierarchy!
just some clarification and some minor remarks

Comment thread README.md Outdated
Comment thread applications/vault-secrets-operator.yaml
Comment thread README.md Outdated
Comment thread components/rhoso/controlplane/networking/openstack-nncp.yaml
Comment thread components/rhoso/dataplane/nodeset/nodeset.yaml
Comment thread components/rhoso/dataplane/deployment/dataplane-deployment.yaml
Copy link
Copy Markdown

@aharivel aharivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@holser holser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@cjeanner cjeanner merged commit 856a2b6 into main Mar 5, 2026
3 checks passed
@cjeanner cjeanner deleted the cleaning branch March 5, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants