Enable custom password requirements and rejects#677
Merged
fmount merged 1 commit intoopenstack-k8s-operators:mainfrom Mar 26, 2026
Merged
Enable custom password requirements and rejects#677fmount merged 1 commit intoopenstack-k8s-operators:mainfrom
fmount merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
fmount
reviewed
Mar 25, 2026
Contributor
fmount
left a comment
fmount
left a comment
There was a problem hiding this comment.
@dciabrin the direction looks good to me. I only have a comment related to the code duplication generated by the ValidatePassword function that we just removed. I think we can go further, remove it entirely and adjust the existing tests to accept an empty PasswordValidator{}.
Update the Password validation interface so that a one can specify custom requirements, rejects or both. Specifying rules is optional, if none are provided, the validation will be performed by enforcing the default rules defined in the libcommon's package. Assisted-By: Claude (claude-sonnet-4.5)
dciabrin
force-pushed
the
custom-pw-validation
branch
from
5d27335 to
f38e6c8
Compare
Contributor
|
/approve |
fmount
approved these changes
Mar 26, 2026
Contributor
|
@dciabrin do you want to try a follow up w/ mariadb-operator? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Password validation interface so that a one can specify custom requirements, rejects or both.
Specifying rules is optional, if none are provided, the validation will be performed by enforcing the default rules defined in the libcommon's package.
Assisted-By: Claude (claude-sonnet-4.5)