[OSPRH-12079] Add mysqld exporter#1236
[OSPRH-12079] Add mysqld exporter#1236openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
I saw that there were some concerns by @dprince on the KSM PR #1056 about adding new images to the openstack version. To be honest I'm not fully sure what the final resolution there is and what's required to be done to add new images. I saw there were concerns about the image being set to nil in an old target version in the openstackversion. So I added a check for that. If it's nil, then openstack-operator will set the image to empty string and telemetry-operator will default it with its webhook to the image set here: https://github.com/openstack-k8s-operators/telemetry-operator/blob/main/api/v1beta1/ceilometer_types.go#L44 Once the target version is changed to a newer version, which includes the mysqld_exporter image, then the image gets set by the openstack-operator similarly to all other images. Did I miss something? Are there some other concerns I should address? |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This adds support for deploying the mysqld exporter as part of ceilometer CR. This is very similar to #1056
Depends-On: openstack-k8s-operators/telemetry-operator#571