Skip to content

Do not update status when reconciler exits due to panic#1485

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
ratailor:OSPRH-17071
Jun 13, 2025
Merged

Do not update status when reconciler exits due to panic#1485
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
ratailor:OSPRH-17071

Conversation

@ratailor
Copy link
Copy Markdown
Contributor

@ratailor ratailor commented Jun 11, 2025

Currently we use deferred call to always update the status field when Reconcile call exits, which seems correct for any other error except when Reconciler exits due to panic.

This change adds a call to recover function and try to handle panic and log error.

Closes: OSPRH-17071

Currently we use deferred call to always update the status
field when Reconcile call exits, which seems correct for
any other error except when Reconciler exits due to panic.

This change adds a call to recover function and try to
handle panic and log error.

Closes: OSPRH-17071
@openshift-ci openshift-ci Bot requested review from lewisdenny and viroel June 11, 2025 05:45
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b7c919aa7274447ea2745360f8b0747a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 09s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 14m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 46m 57s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 14m 05s
openstack-operator-tempest-multinode RETRY_LIMIT in 14m 24s

Copy link
Copy Markdown
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, ratailor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ratailor
Copy link
Copy Markdown
Contributor Author

recheck

@openshift-merge-bot openshift-merge-bot Bot merged commit 2641fcf into openstack-k8s-operators:main Jun 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants