Skip to content

Remove go.work before container build#1881

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:remove_go_work
Apr 12, 2026
Merged

Remove go.work before container build#1881
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
stuggi:remove_go_work

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 12, 2026

The go.work file is generated by the CI environment which may have a higher Go version than the build image (go-toolset). This causes build failures when go.work references a Go version that the build image does not provide. Since the Dockerfile builds a single module, go.work is not needed and can be safely removed before building.

@openshift-ci openshift-ci Bot requested review from abays and fultonj April 12, 2026 13:23
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 12, 2026

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322325 bytes (315KB)
Base branch size 322325 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

The go.work file is generated by the CI environment which may have a
higher Go version than the build image (go-toolset). This causes build
failures when go.work references a Go version that the build image
does not provide. Since the Dockerfile builds a single module, go.work
is not needed and can be safely removed before building.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b8c515cb17bd45b49cd08f12768f7c58

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 33s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT Host unreachable in 1h 12m 41s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 43m 20s
✔️ openstack-operator-edpm-baremetal-minor-update SUCCESS in 2h 09m 16s

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 12, 2026

recheck

@stuggi stuggi requested review from dprince and fmount April 12, 2026 17:55
Copy link
Copy Markdown
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit a7cfd4b into openstack-k8s-operators:main Apr 12, 2026
8 checks passed
@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 13, 2026

/cherry-pick 18.0-fr5

@openshift-cherrypick-robot
Copy link
Copy Markdown

@stuggi: #1881 failed to apply on top of branch "18.0-fr5":

Applying: Remove go.work before container build
Using index info to reconstruct a base tree...
M	config/operator/manager_operator_images.yaml
M	hack/export_operator_related_images.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/export_operator_related_images.sh
CONFLICT (content): Merge conflict in hack/export_operator_related_images.sh
Auto-merging config/operator/manager_operator_images.yaml
CONFLICT (content): Merge conflict in config/operator/manager_operator_images.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Remove go.work before container build

Details

In response to this:

/cherry-pick 18.0-fr5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants