-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add neutron network function tools #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add neutron network function tools #27
Conversation
halucinor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인해야하는 것
- try except가 유의미하게 사용되고 있는지, 대부분의 경우 불필요해보입니다.
- Exception 직접 raise할 필요가 있는지?
- 코드로 이해가 가능한데 불필요한 주석을 작성했는지
tests/conftest.py
Outdated
| with patch( | ||
| "openstack_mcp_server.tools.neutron_tools.openstack.connect", | ||
| return_value=mock_conn | ||
| ) as mock_func: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
죄송합니다 제가 as mock_func를 써서 쓰셨겠군요
ruff rule에서 잡힙니다...
| ) as mock_func: | |
| ): |
tests/conftest.py
Outdated
| with patch( | ||
| "openstack_mcp_server.tools.base.get_openstack_conn", | ||
| return_value=mock_conn | ||
| ) as mock_func: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ) as mock_func: | |
| ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as 절이 전부 추가되어있는데 제가 제거해서 커밋 할까요?
halucinor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* feat(neutron): Add network feature * feat(neutron): Add network feature test * chore(neutron): code linting * fix(neutron): remove comments * test(neutron): Remove unnecessary tests * fix(neutron): remove comments in test * fix(neutron): openstack connection call fix in confest
Overview
Key Changes
Features
get_neutron_networks()create_network()get_network_detail()update_network()delete_network()Testing
Get Network Operations
Create Network Operations
Get Network Detail Operations
Update Network Operations
Delete Network Operations
Related Issues
Additional context