Skip to content

bug: Delete is_bootable attribute #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

bug: Delete is_bootable attribute #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/openstack_mcp_server/tools/block_storage_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def create_volume(
description: str | None = None,
volume_type: str | None = None,
availability_zone: str | None = None,
bootable: bool | None = None,
image: str | None = None,
) -> Volume:
"""
Expand All @@ -121,7 +120,6 @@ def create_volume(
:param description: Optional description for the volume
:param volume_type: Optional volume type
:param availability_zone: Optional availability zone
:param bootable: Optional flag to make the volume bootable
:param image: Optional Image name, ID or object from which to create
:return: The created Volume object
"""
Expand All @@ -141,7 +139,6 @@ def create_volume(
volume = conn.block_storage.create_volume(
size=size,
image=image,
bootable=bootable,
**volume_kwargs,
)

Expand Down
5 changes: 0 additions & 5 deletions tests/tools/test_block_storage_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ def test_create_volume_success(
mock_conn.block_storage.create_volume.assert_called_once_with(
size=10,
image=None,
bootable=None,
name="new-volume",
description="Test volume",
volume_type="ssd",
Expand Down Expand Up @@ -435,7 +434,6 @@ def test_create_volume_minimal_params(
mock_conn.block_storage.create_volume.assert_called_once_with(
size=5,
image=None,
bootable=None,
name="minimal-volume",
)

Expand Down Expand Up @@ -468,20 +466,17 @@ def test_create_volume_with_image_and_bootable(
"Bootable volume from image",
"ssd",
"nova",
True,
"ubuntu-20.04",
)

assert isinstance(result, Volume)
assert result.name == "bootable-volume"
assert result.id == "vol-bootable"
assert result.size == 20
assert result.is_bootable

mock_conn.block_storage.create_volume.assert_called_once_with(
size=20,
image="ubuntu-20.04",
bootable=True,
name="bootable-volume",
description="Bootable volume from image",
volume_type="ssd",
Expand Down