Skip to content

Follow up on persistent storage changes (PR#107)#108

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
umago:pvc-follow-ups
May 28, 2026
Merged

Follow up on persistent storage changes (PR#107)#108
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:lcore-migrationfrom
umago:pvc-follow-ups

Conversation

@umago
Copy link
Copy Markdown
Contributor

@umago umago commented May 27, 2026

This patch addresses the latest review nits from PR#107.

  • Rename the database to "openstack-lightspeed-database"
  • Improve the info message when reusing an existing PVC with a matching
    size

@openshift-ci openshift-ci Bot requested review from Akrog and lpiwowar May 27, 2026 12:39
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 31feebce-b257-4178-aa84-9cb73f3c5bd0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Akrog
Akrog previously approved these changes May 27, 2026
Copy link
Copy Markdown
Contributor

@Akrog Akrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@umago
Copy link
Copy Markdown
Contributor Author

umago commented May 27, 2026

/test openstack-lightspeed-kuttl-4-18

Hmm wonder if my previous patch introduced a race condition when cleaning up the PVC for the test that does the custom size (not the default one)

@umago umago force-pushed the pvc-follow-ups branch from 0f5a1c8 to 1301362 Compare May 27, 2026 13:22
@openshift-ci openshift-ci Bot removed the lgtm label May 27, 2026
@umago umago marked this pull request as draft May 27, 2026 13:25
This patch addresses the latest review nits from PR#107.

* Rename the database to "openstack-lightspeed-database"
* Improve the info message when reusing an existing PVC with a matching
  size
* Clean-up the PVC as part of the
  cleanup-openstack-lightspeed-instance.yaml kuttl test

Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
@umago umago force-pushed the pvc-follow-ups branch from 1301362 to fa63694 Compare May 27, 2026 13:28
@umago umago marked this pull request as ready for review May 27, 2026 13:28
@openshift-ci openshift-ci Bot requested a review from Akrog May 27, 2026 13:28
Copy link
Copy Markdown
Contributor

@lpiwowar lpiwowar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, lpiwowar, umago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Akrog,lpiwowar,umago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 73411c1 into openstack-lightspeed:lcore-migration May 28, 2026
7 checks passed
@umago umago deleted the pvc-follow-ups branch May 29, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants