Skip to content

Include a Content-Length header with all PUT/POST requests #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanquillin merged 3 commits into from
Oct 10, 2014
Merged

Include a Content-Length header with all PUT/POST requests #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba084b3
Updated documentation for BuildDefaultRequestSettings to correctly re…
sharwell Sep 15, 2014
7bdfadd
Include a Content-Length header with PUT/POST requests that do not in…
sharwell Sep 15, 2014
1b3350b
Fix paths in DeploymentItem attributes in UserObjectStorageTests
sharwell Sep 15, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/corelib/Providers/Rackspace/ProviderBase`1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,10 +606,12 @@ protected Response StreamRESTRequest(CloudIdentity identity, Uri absoluteUri, Ht
/// The base implementation returns a <see cref="JsonRequestSettings"/> object initialized with the following values.
///
/// <list type="bullet">
/// <item>The <see cref="RequestSettings.RetryCount"/> is 2.</item>
/// <item>The <see cref="RequestSettings.RetryCount"/> is 0.</item>
/// <item>The <see cref="RequestSettings.RetryDelay"/> is 200 milliseconds.</item>
/// <item>The <see cref="RequestSettings.Non200SuccessCodes"/> contains <see cref="HttpStatusCode.Unauthorized"/> and <see cref="HttpStatusCode.Conflict"/>, along with the values in <paramref name="non200SuccessCodes"/> (if any).</item>
/// <item>The <see cref="RequestSettings.UserAgent"/> is set to <see cref="UserAgentGenerator.UserAgent"/>.</item>
/// <item>The <see cref="RequestSettings.AllowZeroContentLength"/> is set to <see langword="true"/>.</item>
/// <item>The <see cref="RequestSettings.ConnectionLimit"/> is set to <see cref="ConnectionLimit"/>.</item>
/// <item>Other properties are set to the default values for <see cref="JsonRequestSettings"/>.</item>
/// </list>
///
Expand All @@ -629,6 +631,7 @@ protected virtual RequestSettings BuildDefaultRequestSettings(IEnumerable<HttpSt
RetryDelay = TimeSpan.FromMilliseconds(200),
Non200SuccessCodes = non200SuccessCodesAggregate,
UserAgent = UserAgentGenerator.UserAgent,
AllowZeroContentLength = true,
ConnectionLimit = ConnectionLimit,
};
}
Expand Down
12 changes: 6 additions & 6 deletions src/testing/integration/Providers/Rackspace/UserObjectStorageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,7 @@ public void TestCreateObjectWithMetadata()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestCreateLargeObject()
{
IObjectStorageProvider provider = Bootstrapper.CreateObjectStorageProvider();
Expand Down Expand Up @@ -1648,7 +1648,7 @@ public void TestCreateLargeObject()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestVerifyLargeObjectETag()
{
IObjectStorageProvider provider = Bootstrapper.CreateObjectStorageProvider();
Expand Down Expand Up @@ -1698,7 +1698,7 @@ public void TestVerifyLargeObjectETag()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestExtractArchiveTar()
{
CloudFilesProvider provider = (CloudFilesProvider)Bootstrapper.CreateObjectStorageProvider();
Expand Down Expand Up @@ -1750,7 +1750,7 @@ public void TestExtractArchiveTar()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestExtractArchiveTarGz()
{
CloudFilesProvider provider = (CloudFilesProvider)Bootstrapper.CreateObjectStorageProvider();
Expand Down Expand Up @@ -1807,7 +1807,7 @@ public void TestExtractArchiveTarGz()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestExtractArchiveTarBz2()
{
CloudFilesProvider provider = (CloudFilesProvider)Bootstrapper.CreateObjectStorageProvider();
Expand Down Expand Up @@ -1863,7 +1863,7 @@ public void TestExtractArchiveTarBz2()
[TestMethod]
[TestCategory(TestCategories.User)]
[TestCategory(TestCategories.ObjectStorage)]
[DeploymentItem("DarkKnightRises.jpg")]
[DeploymentItem("Providers/Rackspace/CloudFiles/DarkKnightRises.jpg")]
public void TestExtractArchiveTarGzCreateContainer()
{
CloudFilesProvider provider = (CloudFilesProvider)Bootstrapper.CreateObjectStorageProvider();
Expand Down
2 changes: 1 addition & 1 deletion src/testing/integration/integration.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
</ItemGroup>
<ItemGroup>
<Content Include="Providers\Rackspace\CloudFiles\DarkKnightRises.jpg">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</Content>
</ItemGroup>
<Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" />
Expand Down