refactor: improve CLI reliability and architecture#17
Merged
thibaultleouay merged 1 commit intomainfrom Mar 23, 2026
Merged
Conversation
- Thread context.Context through all API calls so Ctrl+C cancels in-flight requests - Fix race condition in `run` command: collect results per goroutine, print sequentially - Fix spinner/output overlap: stop spinner after API call, before rendering - Move ResolveAccessToken from internal/cli to internal/auth to avoid fragile dependency - Pass through original errors in monitor commands instead of swallowing them - Fix TOCTOU in monitor apply: compute diff locally, then apply once - Add fsync to lock file writes to prevent corruption on crash - Use net.SplitHostPort for TCP URI parsing to support IPv6 - Add login/logout commands with XDG-based token persistence - Add status report CRUD commands via Connect RPC - Add global --json, --quiet, --debug, --no-color flags - Add centralized error formatting for Connect RPC errors - Add signal handling with double Ctrl+C force exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runcommand: collect results per goroutine, print sequentially