Skip to content

fix: resolve 15 critical and high severity bugs across CLI#18

Merged
thibaultleouay merged 1 commit intomainfrom
cli-1
Mar 23, 2026
Merged

fix: resolve 15 critical and high severity bugs across CLI#18
thibaultleouay merged 1 commit intomainfrom
cli-1

Conversation

@thibaultleouay
Copy link
Copy Markdown
Member

Critical fixes:

  • Fix region mapping collision causing silent data loss on round-trip (Koyeb/Railway regions now use disambiguated codes like koyeb_fra, railway_us-west2)
  • Fix global koanf instance causing state pollution between ReadConfig/ReadOpenStatus calls
  • Fix partial failure in ApplyChanges leaving lock map in inconsistent state
  • Fix spinner leak when statusToSDK fails in status-report list/add-update
  • Fix TCP monitor creation accepting zero/invalid port values

High severity fixes:

  • Fix strconv.Atoi error silently ignored in httpMonitorToLocal/tcpMonitorToLocal
  • Fix DNS monitor info returning opaque "unknown monitor type" error
  • Fix ResolveToken silently discarding file read errors (e.g. permission denied)
  • Fix confirmation prompt blocking in non-interactive environments (added TTY check)
  • Fix delete commands showing confirmation with empty ID before validation
  • Fix --component-ids "" silently clearing components on status-report update
  • Fix monitor trigger printing plain text in --json mode
  • Fix http.DefaultClient used without timeout (added api.DefaultHTTPClient with 30s)
  • Fix unknown jobType aborting entire result set in run command
  • Fix monitor import truncating output file before API call succeeds

Critical fixes:
- Fix region mapping collision causing silent data loss on round-trip
  (Koyeb/Railway regions now use disambiguated codes like koyeb_fra, railway_us-west2)
- Fix global koanf instance causing state pollution between ReadConfig/ReadOpenStatus calls
- Fix partial failure in ApplyChanges leaving lock map in inconsistent state
- Fix spinner leak when statusToSDK fails in status-report list/add-update
- Fix TCP monitor creation accepting zero/invalid port values

High severity fixes:
- Fix strconv.Atoi error silently ignored in httpMonitorToLocal/tcpMonitorToLocal
- Fix DNS monitor info returning opaque "unknown monitor type" error
- Fix ResolveToken silently discarding file read errors (e.g. permission denied)
- Fix confirmation prompt blocking in non-interactive environments (added TTY check)
- Fix delete commands showing confirmation with empty ID before validation
- Fix --component-ids "" silently clearing components on status-report update
- Fix monitor trigger printing plain text in --json mode
- Fix http.DefaultClient used without timeout (added api.DefaultHTTPClient with 30s)
- Fix unknown jobType aborting entire result set in run command
- Fix monitor import truncating output file before API call succeeds
@thibaultleouay thibaultleouay merged commit 63eefef into main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant