Skip to content

Fix publishables returned by with_id when given a UUID that starts with a digit #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

Fix publishables returned by with_id when given a UUID that starts with a digit #299

merged 1 commit into from
Feb 22, 2021

Conversation

@Dantemss
Copy link
Member

@Dantemss Dantemss commented Dec 9, 2020

Feeding it directly to the where apparently uses to_i to turn it into a number which is bad.
We want Integer(...) rescue nil instead

@Dantemss Dantemss self-assigned this Dec 9, 2020
@Dantemss Dantemss changed the base branch from master to main January 20, 2021 16:57
@Dantemss Dantemss requested a review from nathanstitt January 20, 2021 17:03
@Dantemss Dantemss merged commit e03a86c into main Feb 22, 2021
@Dantemss Dantemss deleted the fix_with_id branch February 22, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanstitt nathanstitt Awaiting requested review from nathanstitt

Assignees

@Dantemss Dantemss

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Dantemss