Set X-Requested-With XMLHttpRequest when querying collaborators #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanstitt
reviewed
Feb 23, 2021
app/assets/javascripts/admin.js
Outdated
| "GET", | ||
| "/admin/publications/collaborators?collaborators_query=" + $("#collaborators-query").val(), true | ||
| ); | ||
|
|
Member
There was a problem hiding this comment.
I have no idea why we're using old-old-old school XMLHttpRequest here. Since this will only be used by people with somewhat modern browsers, we can use fetch which is so much simpler. try this:
fetch(`/admin/publications/collaborators?collaborators_query=${$("#collaborators-query").val()}`).then((resp) => {
eval(resp.responseText);
});I'm not 100% sure if the response (resp var) will have a responseText property though. You might need to put a console.log(resp) or a debugger in before the eval to play with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise Rails thinks it's a cross-origin request and fails.