Skip to content

Speed up the slug tags migration #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Speed up the slug tags migration #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/models/exercise.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ def before_publication
end
end

protected

def has_questions
return unless questions.first.nil?
errors.add(:questions, "can't be blank")
Expand Down
4 changes: 2 additions & 2 deletions db/migrate/20220302162344_create_slug_tags.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ class CreateSlugTags < ActiveRecord::Migration[6.1]
def up
Exercise.preload(:publication).in_batches(of: 100, load: true) do |exercises|
Exercise.transaction do
exercises.each(&:save) # creates the slug tags but does not set updated_at
exercises.update_all(updated_at: Time.current) # invalidates the exercise cache
exercises.each(&:set_slug_tags)
exercises.update_all updated_at: Time.current
end
end
end
Expand Down