Core-1551: Make list for dropdown links#2829
Merged
RoyEJohnson merged 2 commits intomainfrom Feb 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the main-menu dropdown markup to use semantic lists for dropdown links (CORE-1551), with small related keyboard-navigation and styling adjustments.
Changes:
- Convert dropdown menu container from a
<div>to a<ul>and wrap eachMenuItemlink in an<li>. - Update keyboard navigation to focus the first available link via
querySelector('a'). - Add basic list styling reset for the dropdown menu.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/layouts/default/header/menus/main-menu/dropdown/use-navigate-by-key.ts | Broadens dropdown ref element type and updates initial focus targeting to work with the new list structure. |
| src/app/layouts/default/header/menus/main-menu/dropdown/dropdown.tsx | Changes dropdown contents to <ul> and wraps menu links in <li> elements. |
| src/app/layouts/default/header/menus/main-menu/dropdown/dropdown.scss | Adds list-style-type: none; to remove list bullets for the new <ul>. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RoyEJohnson
force-pushed
the
core-1551-make-list-for-subject-menu-items
branch
from
335e0cd to
9b5ed83
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jivey
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CORE-1551