Make render_list reconnect if the renderd connection is lost #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Added this for testing purposes to a release candidate for version 0.6 (#227). See the issue for debian packages and please help testing. |
Collaborator
Author
|
Applied it and had no issues, ready to become part of the next release candidate. |
ldeffenb
reviewed
Jul 13, 2021
ldeffenb
left a comment
ldeffenb
left a comment
There was a problem hiding this comment.
I notice that this doesn't retry the cmd that failed?
Member
|
Yes I realised that recently but then forgot about it again... I've opened #240 to fix it. |
pantierra
deleted the
feature/reconnect-render-list-after-lost-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rerolled #128 by @tomhughes on the latest codebase.
This is up for testing.